Closed (fixed)
Project:
Forward
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2006 at 20:41 UTC
Updated:
18 Nov 2009 at 22:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
designerbrent commentedThis update add security functionality to the block so that if the user doesn't have access permission to see the block, it won't show. This is a replacement for the previous patch. Not an updgrade.
Comment #2
Rosamunda commentedAre plans to add this at the module?
As I´m not a programmer, nor have programmer skills, it´s kinda difficult to me to patch, and must admit that never could make any patching correctely by myself.
It would be very kind if someone could upload the module already patched with this EXCELLET feature!!!
This feature should be part of the module indeed! Most users won´t click a link to go to a forward page... (I don´t)...
Thank you very much for your patience and help!!!
:-)
Comment #3
designerbrent commentedAnyone interested in seeing this get into the module? What do I need to get this reviewed and patched into the main module?
Comment #4
manoloka commentedI'm with you but don't have the skill to do it :-(
Comment #5
missym commentedI added a request for a similar feature here:
http://drupal.org/node/252026
I'd like to add a feature to Forward to send a link to any page (not just nodes) by adding another argument so that it looks like this www.mysite.com/forward/linktopath/linktoargument so that if you want to send a link to a node you can say www.mysite.com/forward/node/1234 or another module type www.mysite.com/forward/modulename/argument. You'd need a way to put the code on your page and some revisions to the submit form to handle the send.
I put a $50 bounty on it. If you could use this feature, it would be great if you could kick in some, too.
Comment #6
grendzy commentedI don't have a patch for this, but I wrote a blog post about implementing this block as a custom module:
http://www.opensourcery.com/blog/dylan-tack/creating-block-contributed-m...
Someone could probably roll this into a patch if there's enough interest.
Comment #7
grendzy commentedComment #8
grendzy commentedComment #9
marco88 commentedI would like to use this block to replace the "tell a friend" module
Subscribing
Marc.
Comment #10
srjoshI'm not entirely certain if I should throw another patch into the works here, but I would love some feedback on this. It's not as elaborate as the previous one, but it seems to do the job. I haven't tested the block form too much, as we decided the link looked good for our purposes.
Comment #11
srjoshComment #12
srjoshI suppose before I submit a patch I should probably make sure it really works as advertised. *sigh* version .1
Comment #13
srjoshnow with more admin options.
Comment #14
eyecon-1 commentedThis patch seems to break the current release forward-6.x-1.5. In fact, it breaks the site. Fortunately I was testing this on a local machine so NBFD.
With panels 3 now very stable, I want to use a revised node view. However, that requires that this be in a block so that you can create a forward pane in the panel.
Comment #15
mkalkbrennerSorry, I didn't notice this issue before and created a similar one with small differences:
#398234: Provide Forward Block
Comment #16
seanrLet's combine the patches and get a new one up here and I'll test it. Please be sure to update to the latest version; there have been recent changes.
Comment #17
CarbonPig commentedsubscribe
Comment #18
joachim commentedThe patches in #12 and #13 are unusable because they have no context and the code is going in the wrong places.
Please use 'diff -up' to generate your patches.
I'm having a look at reworking the code from them into the current release.
However, I disagree with some of the implementation.
In particular:
> '#options' => array('link' => 'link', 'form' => 'form','blocklink' => 'block link','blockform' => 'block form'),
Adding two more options creates much more mess to check each time there's a possibility to output something from this module.
I would suggest:
- store blocklink/blockform as settings for the block.
- add only one option to form/link so we have form/link/none.
This means you'd choose 'none' if you are enabling the block, and also the 'none' option would let advanced themers do their own theming of the forwarding link or form.
Comment #19
joachim commented... which is pretty much the approach the patch by mkalkbrenner posted at #398234: Provide Forward Block does.
Here is that patch re-rolled for the current release. (Diffed from my SVN rather than CVS, but the check-in there is the latest release of this module.)
Comment #20
seanrThanks for your work. I'm going to test that this week. Can we get some others of you to try it as well and make sure it all works?
Comment #21
joachim commentedOne tweak, which could probably be done as a subsequent issue and patch:
the block doesn't take the value of forward_link_title to make the link text.
Comment #22
seanrLooks perfect. I just fixed the omission mentioned in #21 and committed it. Thank you very much. I'll have a new release out soon but the dev package should update later today.
Comment #23
mkalkbrennerI was excited as I noticed today that my patch from #398234: Provide Forward Block went into forward 6.x-1.10 release. Thanks to joachim for merging it at #19.
But I was suprised that a FIXME comment I added made it into the release, too.
My patch added the FIXME comment and disabled the dead code I found in forward.module during working in the patch.
Now it's up to the author of forward to fix this or completely remove the dead code.
Comment #24
seanrI left it in for later review but then forgot about it. I'll clear that out in the next release. Marking this issue fixed.