lorinpda [lorinpda]

Tumblr Connect module contribution attached.

Hi,
I am updating my CVS application:
-- Adding a Drupal 7 version of the Tumblr Connect Module (tumblr_connect-7.x.tar.gz).
-- Replacing the file "tumblr_connect.tar_.gz" with a new updated Drupal 6 version of the Tumblr Connect Module ( new file tumblr_connect-6x.tar.gz).

Changed the database table field "post_id" size to big int.

Thank you.

Hi Kiamlaluno,
Thank you so much for the clarification. Please review the Drupal 7 version (tumblr_connect-7.x.tar_.gz).

I apologize for any inconvenience. We've had a few folks contact us directly and request the Drupal 7 version of our module. Thus the choice of Drupal 7 tumblr_connect-7.x.tar_.gz (versus our Drupal 6 version).

Again thank you so much :)

Wishing everyone a happy holiday
Lorin

Hi,
Thank you so much. I've attached a new version.

After testing against Drupal 7 rc3 changed 3 listings:

• tumblr_connection_class.inc :
  • methods addPost and modifyPost added new statement to determine existence of taxonomy terms:
    

    if (!empty($node->field_tags) ) {
     ... process taxonomy terms ..... 
    

• tumblr_connect_config_class.inc
  • method addOrModify() changed exception capture to standard try/catch
    

     try {
            $result = db_update('tumblr_connect_config')->fields($config->toArray())->execute();
          } catch (Exception $e) {
            throw new tumblr_database_exception(t('Unable to update tumblr config'));
          }
    

• tumblr_connect.module
  • method tumblr_connect_admin_settings_submit() added a success message:
    

     drupal_set_message(t('Tumblr Connect Config Updated Successfully.'));
    

Thank you.
Lorin

Hi,
I am posting a new version. Minor revision, found one line of unused code. New version attached.

Thank you
Lorin

Hi ,
Thank you so much for reviewing our module. I am posting an updated version.

Fixed point 3. We were using a Drupal 6 theme function to display the condition of "No Followers Found", That theme function does not exist in Drupal 7. I've updated the code so that it uses Drupal 7 theme_table method, empty condition (i.e. a message displayed when there are no rows ).

Our module supports the basic "regular" Tumblr post type. A Tumblr regular post type contains 2 fields (Title and Body) along will zero to many taxonomy terms. Therefore, if you include an image or a video in your Drupal body field, our module will publish the image and video in the corresponding Tumblr body field. To summarize, we map the Drupal fields to the Tumblr fields. We'll be happy to entertain enhancements, however our current version is limited to a Tumblr "regular" post type.

Hope that helps.
Lorin

Hi,
I noticed that the component on this application was set to miscellaneous. Thus, I changed to "new project application". Don't know if that makes a difference :)

Hi,
I've refactored the source code class and interface names to comply with the naming conventions specified here http://drupal.org/node/608152.
No functional changes.

Thank you in advance.
Lorin

Hi All,
Thank you for your comments and support. Per the latest docs here http://drupal.org/node/1011698, I've submitted a corresponding application for permission to create full projects.
The request for permission to create full projects is located here: http://drupal.org/node/1074950

I've pitched in by reviewing other applications for CVS (now full Git) accounts. Reviewing a module application is a great learning experience. I highly recommend everyone waiting for approval to volunteer and review your fellow applicants. The maintainers of these issue queues have a huge workload. Please consider helping out by reviewing your fellow applicants.

Thank you.
Lorin