If you see on this page:

http://drupal.org/project/Modules/name (4.7)

The 'Download' link under Views, Views Bonus Pack, Views Bookmarks, etc module links to another module's tarball:

http://drupal.org/files/projects/content_moderator-4.7.x-1.x.tar.gz

This is weird and seems something either went wrong with the update queries or with new code.

Comments

Gurpartap Singh’s picture

    Link broken for these 4.7.x modules:
  • CVS management/tracker
  • Dashboard
  • flickrhood
  • Inventory Management
  • LiveJournal CrossPoster
  • modr8
  • Node Access Arbitrator
  • Node Clone
  • Node Queue
  • Organic Groups Mandatory Group
  • Panels
  • Project
  • Project issue tracking
  • Publishing
  • Taxonomy Breadcrumb
  • Taxonomy Lineage
  • Video
  • Views
  • Views Bonus Pack
  • Views Bookmarks
  • Weather
dww’s picture

Priority: Normal » Critical

yup. i've seen it in other places in the last day, and someone just reported it on the infrastructure email list, too.

the code that generates these pages is some of the most complicated in all of project.module, and the SQL queries involved are enough to drive anyone insane. i certainly broke these in the initial patches for the new release system (see http://drupal.org/node/83339#comment-145292 and the next few comments/patches thereafter, as well as http://drupal.org/node/93471).

hopefully nedjo, kjartan, and/or myself can find a time to dig into this in the near future. bumping to critical since *lots* of people try to download views. ;)

dww’s picture

wow, thanks for the list (you posted just as i was posting).

that looks like all the modules that have had activity recently. :( something's going on in the queries trying to grab the latest download for a given version that's getting confused. i'm thinking the patch we made in http://drupal.org/node/93471 just isn't handling all the cases properly. that'd definitely be a good place to start investigating.

dww’s picture

Assigned: Unassigned » dww
Status: Active » Fixed

woo hoo, problem solved! http://drupal.org/node/93471 was indeed the culprit.

in cases where a module has more than 1 release that's compatible with a given version of core, we end up having to do an extra SQL query to get the right download link, since we can't just do it correctly in the initial query (at least, that's how it's always been -- maybe we can/should take another look at this). so in #93471, we were trying to fix the case where you're filtering by all versions, and ended up breaking the case where you filter by a specific one. ;) there's all this dynamic SQL-generation going on in there, depending on various things, and we used a $values array to build up this extra query. however, we never unset it, and the way we were using it is such that we kept using the same nid from the first project that needed it on every other project that needed it. :( so, all we had to do was unset($values); before we do a new query, and all is well.

committed to DRUPAL-4-7--2 branch as revision 1.239.2.13.2.12 of project.module. thankfully, someone was in #osuosl in IRC, and was willing/able to run "cvs update" in there for me, so things are all happy again on d.o.

phew! ;)
-derek

Anonymous’s picture

Status: Fixed » Closed (fixed)