Turkish Bible Verse Finder / Incil Ayet Bulucu

This version has a little better compliance with Drupal coding standards.

I do not have a forward facing drupal instalation to show this off at, but you can see the general effect of what is supposed to happen here: http://alerque.com/inciltest.php.

@kiamlaluno: My original does have a such a description and comparison. Here they are again with some expansions.

This module is a filter that scans Turkish language content for Turkish bible verse references and converts them to links to a Turkish bible search site. Also according to a preference in the module, it can use the API of that site to fetch the verse content and display it as a tooltip on the link.

There are no comparable projects that handle Turkish bible verse references or that use this particular API. The module is similar in concept and implementation to things like "scripture filter" or "reftagger" that work on english content using various english bible site APIs.

Planned features will be to properly internationalize the strings so it can be translated, particularly for administrators of multilingual sites. Also it will include multiple bible translation support as soon as the API it uses does. More tooltip formatting options are also planned, along with some sort of tag to import the verse content into the article instead of just placing a tooltip.

I am attaching a newer version with some more coding standards issues fixed, the addition of a readme file and some general work on the module.

@kiamlaluno: Please read the full text of my comment at #4. The module does exactly one thing with a minor preference as to how that is done, and I described that. I also described possible future features AND compared it to other modules that are available. The main point is that there are NONE that work for Turkish source texts or against the API of a Turkish language bible site. Searching for "bible" is pointless, try "kutsal kitap" or "incil". 0 results.

It is not feasible to just translate an existing project because the site API's the English language projects work against don't have Turkish source texts! This project uses the API of a Turkish language site.

For anybody trying to install and review this module who does not speak Turkish, here are the basics. After installing to the modules folder and enabling under the modules page, go to preferences and make sure at least the "araçipucu" preference is enabled, checking both boxes and saving is sufficient. Then make sure you enable the filter for your input method and then save a node with the following sentence:

Bugün Mezmurlar 23'ü okudum. Akşam üzere Vahiy 7:11-14 okumayı planlanıyorum.

When you view the saved object, the filter should find and link the two verse references as well as retrieve the verse content and show it in a tooltip on the link.

Also the attached version has a small bugfix to do with default values for preferences over my last submission.

I have migrated this module to a git sandbox, fixed some bugs and added a few new features. It is tested and working in Drupal 6x. The test content from my #8 comment is still relevant.

Drupal 7x support is upcoming but I have several active projects using this in 6x and it would be nice to let people upgrade modules in the usual way. It has been over six months since I first submitted this for review :)

Thanks @zzolo.

I added English translations of the module title and description. I figured since the module is only relevant to Turkish users since it uses the API of a Turkish-only site that it wouldn't matter, but I don' t mind having an English description to make it easier to moderate either.

No, this is not abandoned. After 5 months of waiting to be reviewed I somehow missed comment #16. I'll review the points mentioned in the next week or so and submit any updates.

All of the issues in comment #16 above have been addressed in the git sandbox:

* bogus file removed from repository
* CVS $Id$ tags removed
* hook implementation docs added
* Module name and description translated to English
* All user facing strings translated to English and used t() except in hook_menu implementation
* All other functions described in a doc block

I have made the change to move from master to a 6.x-1.x branch per the referenced documentation. I have also reviewed the output of the coding tool you mention and fixed most of the issues. I'm down to the line length suggestion which is hard to comply with. In all reasonable cases I have, but there are a few regular expressions that include extensive use of back-references and introducing line breaks makes these very hard to debug.

As the formatting guidelines list numerous examples where the 80 char length SHOULD be ignored, I don't see these special cases as problematic. If they are, please suggest where in the standards a matching example is shown so I know how to procede.

All mentioned issues by all reviewers have been addressed.

• The project page and readme have been updated with better descriptions according to the Drupal project documentation guidelines.
• The help hook was touched up, but there isn't much to say, this is a really simple module, but no other modules does with it does.
• The callback function creation is expensive performance wise but the scoping of the functions don't really leave much option. Considering the expense of the PCRE match being run, this is a minor issue. If there is a better way to do it I'm all ears, but this should not be an issue that stops the module getting approved.