Will the current Organic Groups Notifications module (6.x-2.1) be compatible with Notifications 6.x-4.x?

CommentFileSizeAuthor
#14 dbogn.png69.12 KBmarinex

Comments

rootwork’s picture

Category: support » feature

Any update on this? The project page says:

This version will work with 4.x versions of Messaging, related modules tagged as 4.x, and not yet with Organic Groups

but then also says:

For using with OG <= 6.x-1.1 you need to use the 6.x-1.0 release of Notifications. OG 6.x-1.2 and 1.3 will work with Notifications 6.x-1.1. For newer versions use the latest (either rc, beta or dev) of both.

So do the newest versions of Notifications, Messaging and OG work together? Or does it only work with Notifications 2.x?

Shai’s picture

I'm also interested in knowing what is compatible with what.

tigron’s picture

subscribe

dtarc’s picture

subscribe

rootwork’s picture

Title: Organic Groups Notifications with Notifications 6.x-4.x » Clarify compatibility between Organic Groups Notifications and Notifications 6.x-4.x
Component: Notifications » Documentation
Priority: Normal » Critical

Because it seems unclear whether this is compatible or not, I'm changing the title and marking it as a critical documentation issue.

If, as I imagine, it is the case that they're not compatible, we can move it back to a feature request. But the documentation needs to be addressed one way or the other.

ianchan’s picture

subscribe

SiteFish’s picture

subscribe

nbluto’s picture

This was really killing me. I have a site where this is super important and it stopped working.

If you are using Messaging and Notifications 6x-4.0 you need to use the dev version OG.

This is the dev6 upgrade status notes from the module page at http://drupal.org/project/og

# #799856: Upgrade for Notifications 6.x-4.x was committed, and needs messaging and notifications 4.x version. Note thast messaging module is now dependent on the autoload module.

thepanz’s picture

I found og_notifications 6.x really buggy.. I provided couple of patches for og_notifications in the module issue queue, but ended forking OG module on GIT (https://github.com/thepanz/og/tree/DRUPAL-6--2)..

Should we join our works/tests?

nbluto’s picture

After testing this combination of modules, it does not work. I'm still looking for the correct combination that works.

thepanz’s picture

@bnluto: could you try my "og" (https://github.com/thepanz/og/tree/DRUPAL-6--2) and "notifications" (https://github.com/thePanz/notifications) forks? I'm using them on a production website without bugs..
Please let me know!

Cheers

fuzzy76’s picture

subscribing

marinex’s picture

 @thePanz, Hi your work is great but there are any bugs!!


1) I tested your modules and I created subscription on user account under Groups tab "All content in group subscriptions" and then I created a new post to my group but nothing was sent. I used privatemsg and web (Simple messaging) as sending method.

Update: It is necessary replace in the hook_notifications

'subscription types'
$type['group'] =array (
event_type => 'group',

with

'subscription types'
$type['group'] =array (
event_type => 'node',

2) Under tab "Content type subscriptions" I created subscription with "Node type: Group". It worked well but :
In the Notifications "Queue processing >> Operations" tab I used "Run normal queue processing, same as cron run." and in the "Notifications in queue" the "Total" sumary was bad. Because I created one Group and I had one subscription but it tell me 2 messages in the "Total: 2" and in the queue table on website was only one message. After clicked to "Process queue" there was the "Total: 1" instead 0. After I created another group and this value in the "Total" was incremented to 2 instead 0. In the official Notifications module the value in the "Total" after clicked "Process queue" was 0. Another problem was If I added second subscription "Content type by author" again with "Node type: Group" it sent 2 private messages and the "Total" was 4. After "Process queue" the "Total" was 2 again instead 0.

Update: In the latest dev version of notifications there is no problem.

Is there any fix this bugs?

Thanks

marinex’s picture

StatusFileSize
new69.12 KB

@thePanz, Hi I add printscreen my notifications_queue table.
Marinex

thepanz’s picture

@marinex: so can you confirm that (with Notifications release 4.x-dev) the issue is fixed (without your code edits) ?

Unfortunately I don't have much time to further work in OG and Notification (the job I've done for my client is finish now).. hope that my code could be useful for others, until a *real* solution will appear!

Cheers

marinex’s picture

@thePanz:

I think that problem was fixed without code edits. I use latest 6.x-4.x-dev. But at this time I make large edits in my Notifications and other modules that relates to Notifications because Notification out of box dont work, there are a lot of bugs!!! Everyone who want to use Notifications must patching and editing code :-(

I had to recreate submodule for privatemsg and now is working :-) Privatemsg notifications not working from cron

izmeez’s picture

I have been able to successfully upgrade a Drupal 6.x site with og-2.x to messaging-4.x and notifications-4.x

For details of how see this comment http://drupal.org/node/799856#comment-4760884

Hope that helps. If others can confirm it may allow this issue to be closed.

roball’s picture

OG 6.x-2.x has been updated more than a year ago to support (and depend on) Notifications 6.x-4.x, but unless a stable Notifications 6.x-4.0 will be released, OG's release of 6.x-2.2 can't happen. Any progress here?

izmeez’s picture

@roball, I wonder if a new issue needs to be started to address the question of a stable version of Notifications and new release of og?

We are using more recent versions of og than the official 2.1 release from 2010 March and it came as a surprise to see how many sites according to Drupal.org are using og 2.1 as there are many improvements since then.

roball’s picture

Priority: Critical » Normal

Maybe it helps to open a new ticket, izmeez?

rootwork’s picture

@roball @izmeez So to summarize: The Notifications project page currently reads (under "New in 6.x-4.x version"):

This version will work with 4.x versions of Messaging, related modules tagged as 4.x, and not yet with Organic Groups

but should read:

This version will work with 4.x versions of Messaging, related modules tagged as 4.x, and Organic Groups 2.x-dev

Is that correct? Just trying to get a suggested fix for the module maintainer, so we can get this compatibility finally clarified. Personally, that's all I'm looking for from this issue.

izmeez’s picture

@rootwork, Yes, you are correct "This version will work with 4.x versions of Messaging ... and Organic Groups 2.x-dev"

The only issue is upgrade from Notifications 2.x as the dependency modules cannot be activated without first just remove the Notifications and Messaging modules from the sites/all/modules directory no need to to disable or uninstall. Then enable Autoload, then add Messaging and enable text template, and finally add Notifications, then update.php and check user permissions.

Hope that helps.

rootwork’s picture

Status: Active » Reviewed & tested by the community

Cool. So I am going to mark this as being RTBC (as a documentation issue), with the wording in #22, and possibly a link to #22 as well for those details.

izmeez’s picture

Can anyone else confirm if messaging and notifications 6.x-4.x works with organic groups 6.x-2.x-dev so it may be possible to update the Notifications project page to reflect this?

izmeez’s picture

Status: Reviewed & tested by the community » Needs work

Gosh, I feel like a real idiot. Reminded of the value of test, test and test again.

Yes, I can upgrade to notifications 4.x and og without getting error messages. But, notifications 4.x is not sending out on new content. I have updated the og_notifications issue related to this http://drupal.org/node/799856#comment-4934686

delykj’s picture

Status: Needs work » Reviewed & tested by the community

subscribing

izmeez’s picture

@delykj You changed the status so do you have it working? Were their any specific hurdles?

delykj’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, it was a mistake. Status changed back to "needs work".

rootwork’s picture

Per #1340638: Revert Notifications 4.x upgrade, it appears that OG has moved back to integration with the Notifications 2.x branch with its newest version, since the 4.x branch wasn't yet ready. So given that OG will only work with Notifications 2.x, the Notifications module page should probably read (under "Other modules..." in the "Organic Groups" item) something like:

Compatibility: For use with OG <= 6.x-1.1 you need to use the 6.x-1.0 release of Notifications. OG 6.x-1.2 and 1.3 will work with Notifications 6.x-1.1. For newer versions of OG, use the Notifications 2.x branch.

Thoughts? It would be really nice to finally get this clarified on the Notifications project page.

rsbecker’s picture

This is not entirely accurate, although it is good advice. If you are starting from scratch it would be better to us Messaging/Notifications 6.x-2.x. If you've already built a system with Messaging/Notifications 6.x-4.x, see my as yet unreviewed guide, [#1401228]. Please post comments and suggestions.

rerooting’s picture

Any progress on this? Anyone have success?

I've noticed that this still does not work with 4.x. Group subscriptions do not appear in user/id/notifications/subscriptions though it will still be counted in the total shown on user/id/notifications. Does not appear in subscriptions UI. Appears as an option in content type and notification settings however. No useful errors appearing.

This is with og 2.x-dev btw. It appeared in the content type and notification settings after employing this fix: http://drupal.org/node/925462#comment-4271042

rsbecker’s picture

For all intents and purposes the 6.x-4.x branch is dead.

rerooting’s picture

Ah! This is very very good information to have. Thanks for the clarification!

It might be nice to deprecate it somehow, because it and messaging 4.x are the defacto --dev branches when downloading with drush.

rootwork’s picture

Title: Clarify compatibility between Organic Groups Notifications and Notifications 6.x-4.x » Clarify that the 6.x-4.x branch is dead
Category: feature » task
Priority: Normal » Critical
Status: Needs work » Active

Agreed. The project page should be updated to reflect this.

Marking this as a critical documentation task. But if 4.x really is dead, the 4.x beta should probably be marked unsupported as well, so people won't be tempted.

rsbecker’s picture

There have been some fixes, but messaging and notifications appear to be unmaintained. Dane Powell, who maintains mailhandler and feeds has done some. But the maintainers of OG have given up on the 4.x branch and the current version of og notifications does not work with the 4.x branch.

So, if you are going to use 4.x you must think carefully about what you want to accomplish.

roball’s picture

Title: Clarify that the 6.x-4.x branch is dead » Clarify compatibility between Organic Groups Notifications and Notifications 6.x-4.x
Priority: Critical » Normal

The 6.x-4.x branch is definitely NOT dead - it is more recent than 6.x-2.x, and it also works better (for example see #1780146: V2 or V4, Prod site?.

You only have to use Notifications 6.x-2.x for OG 6.x-2.x - for all other purposes I would suggest to use Notifications 6.x-4.x.

rsbecker’s picture

You might want to look at these.

#799856: Upgrade Notifications to 6.x-4.x

and

[#1401228]

and its child pages. With messaging/notifications 6.x-4.x you cannot use a version of OG released after about Jan. 1, 2012. Even then, you will have to patch og notifications to make reply-to addresses work correctly.

roball’s picture

Status: Active » Fixed

That's what I said - if you use OG 6.x-2.x, you have to use Notifications 6.x-2.x. So I think this issue is solved - OG 6.x-2.x is simply not compatible with Notifications 6.x-4.x, but that does not mean that Notifications 6.x-4.x is dead.

izmeez’s picture

Yes, for og 6.x-2.x notifications 6.x-2.x-dev is needed. Notifications 6.x-2.3 was fixed to prevent multiple notifications when comments edited. It might help if there is a new release for Notification 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.