Closed (fixed)
Project:
Ubercart Google Merchant Integration
Version:
6.x-1.0
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2010 at 17:45 UTC
Updated:
20 Jun 2012 at 07:41 UTC
Again, thank you for this immensely useful module. I recently installed this module, configured successfully, and have only added one product to the Google Merchant Center products list. This process was successfully (except for this: http://drupal.org/node/986688 ) but I'm now having this message in the Recent Log Entries (/admin/reports/dblog) show literally about 30 times per minute:
Details
Type ucgbase
Date Friday, December 3, 2010 - 12:38pm
User admin
Location http://www.<domain>/user/115/edit?destination=admin%2Fuser%2Fuser%2Flist
Referrer http://www.<domain>/admin/user/user/list
Message node updated:
Severity notice
...even though I haven't done anything with the one respective product node i added to Google Merchant Center for days.
How can i make this stop? Is this normal? Can you help me figure out what's going wrong here or how to debug this with more information?
Thanks for any advice or response!
Comments
Comment #1
jaypanThis is a major issue. This module is updating every gbase node on the site on every cron run. I have cron running every hour on my site and as such it's causing troubles.
Comment #2
SchwebDesign commentedIN my case i don't have cron running every hour (only 2x a day), but as mentioned, the gbase nodes are updated much more often as described above.
I do have the Boost module installed as well. is there a possibility this could be causing the problem(s)?
Comment #3
jaypanI'm not 100% sure it's from the cron run. But it's happening in hook_nodeapi() when $op equals load. I commented out line 379:
and that solved the problem.
Comment #4
SchwebDesign commentedgreat feedback. forgive my ignorance... but does that solve the "actual" problem itself or just the appearance of it in the log? What do you think?
Thanks!
Comment #5
jaypanWell, yes and no. It depends on what the actual problem is for you - for me the problem was that it was filling up my database logs, which meant that I had no record of anything going on beyond one day, so it did solve my problem!
Basically, the code that added the entry into the database was in some code that is loaded every single time a node is loaded (any node). So anytime anyone accesses a page, or cron loads a node (for whatever reason) or a module loads a node (which modules often do in order to get relevant info from the node) a new line was added to the database log.
I don't see any reason for this code to be added - it's not adding any relevant info to the database when a node is loaded. I'm thinking it was probably a leftover from testing while he was developing the module.
Now, you may have a separate problem on your site - something that is loading nodes more than need be, but it's doubtful. So I would say yes, this most likely does solve the problem and doesn't just hide one. But there is a slight possibility that you have something else on your site that is loading nodes more than necessary, in which case you have a different problem. But probably not.
Comment #6
SchwebDesign commentedI just wanted to say thanks for your great response - very informative and definitely helped me understand what was going on with that code- thank you!
Indeed, my problem is/was the same as yours, simply filling up the logs with empty info. I will implement your suggestion above to solve the problem and submit here if i still experience anything. Thanks again!
Comment #7
ffriartor commentedwhere do i find this line of code? in which file?
thanks.
Comment #8
SchwebDesign commentedthis is in uc_gbase.module
also note that this module may stop working for you soon if it hasen't already:
http://drupal.org/node/1092142 and
http://drupal.org/node/1116172
Comment #9
compujohnny commented