drafty allow publishing current draft from /admin/content page when node already published when Workbench Moderation 7.x-3.x is enabled

this is a preliminary patch with debug bits in it.

needs cleanup and more testing and more review.

HOWEVER, according to my preliminary tests, it appears to resolve the issue.

Followup tomorrow.

Thanks.

here is a patch without all the noise.

In my local environment this patch works fine.
not sure why the fails.

see #2911357: Fix tests; update for latest to Entity Translation changes

saw an opportunity for improvement.
new patch to follow soon.

setting this to RTBC because the errors appear to be unrelated and I'd rather not have this set to 'needs work'

fixed tests in #2911357-11: Fix tests; update for latest to Entity Translation changes

The only change to this that I think this needs before committing is an admin setting to enable or disable this functionality. I would recommend that it be enabled by default.

This is a pretty important functionality for publishers that publish without using deploy. We intentionaly removed deploy and staging from our end servers and replaced it with drafy , access_unpublished and workbench_moderation , this worked great until we upgraded to workbench_moderatoin 3.x . The patch allows our publishers to once again work on drafts of published content and be able to batch publish from /admin/content when they're ready (using the ubiquitous admin_views module, haven't yet tried without it). Batch publishing for publishers is very important for press releases or major events in our case expected organizational changes of our clients that they need to publish all at once so that media and journalists can see exactly at the same moment in time the changes.

For our current client when they have a press release for this type of event there is normally 40000 hits per hour to the site during the first hour of the press release while journalists and media and the general public hit the website for the big changes that get published. Being able to tee up all the drafts before hand and bulk publish them all at once allows for the site to be ready at the exact time . Without the bulk publishing they'd need to open multiple browser windows and tabs and click several dozen times just for one event. It makes sense to have this functionality and it should be enabled by default.

The patch allows publishing new current drafts of currently published content from the /admin/content window, this makes a lot of good sense.
previously it was possible to do this in workbench_moderation 1.x but with drafty revision/moderation history logic fundamentally changed so we wrote this patch to deal with it and it does the job.

Critical feature request for us!

It could also be considered a Bug , because this WAS possible in workbench_moderation 1.x , so it could be considered a regression in workbench_moderation 3.x (because of the drafty requirement)

Hmm, we should encapsulate this functionality around an if exists('workbench_moderation')
code block.
The code will probably break if using something other than workbench_moderation so it'd be recommended to add the if exists('workbench_moderation') block and probably to the same if statement check to make sure that CFS / CPS is not enabled.

Would have to make sure this won't cause a regression with CFS /CPS or whatever they call that module substitute for workbench_moderation

here's a new patch with the module_exists check.

I was looking at the possibility of writing a test for this. It would be monstrous. Basically copy pasting the tests from admin_views would get part of it, then would maybe have to merge in some of the existing drafty/workbench_moderation test steps into this new test.
It would be one hell of a monstrous test code. However, drafty, workbench_moderation AND admin_views already have their own tests.
I suggest simply running this patch against the existing tests in workbench_moderation , drafty and admin_views , this is something I could do manually and report the test results.

another test would have to be done without admin_views enabled to see if it works without admin_views. I've looked at the patch 21, can't see any way to break it but there's lots of existing simpletests to run.

as for the comments wrapping at 80, no problem I can update that.

this is a bulletproof patch, we've put it into production. Works great.
using
drafty:
7.x-1.0-beta4
with these drafty patches:

#2910310-21: drafty allow publishing current draft from /admin/content page when node already published when Workbench Moderation 7.x-3.x is enabled
#2579205-117: Delete redundant revisions
#2911357-11: Fix tests; update for latest to Entity Translation changes

https://www.drupal.org/files/issues/7x1x_drafty_publish_from_admin_content_page-2910310-21.patch
http://drupal.org/files/issues/fix_head_tests_of_drafty7x1x-11.patch
http://drupal.org/files/issues/drafty-n2579205-116.patch

entity_translation 7.x-1.0-beta7

with these patches:

http://drupal.org/files/issues/spelling_mistake_2907275.patch
http://drupal.org/files/issues/entity_translation-translation_status_confusing-2908096-5.patch
http://drupal.org/files/issues/static_cache_for-2557429-17.patch
http://drupal.org/files/issues/entity_translation-2734295-4.patch

workbench_moderation 7.x-3.0+5-dev (2017-02-05)
with these patches:

http://drupal.org/files/issues/upgrade_from_1x3_to_3x_fails-2428371-51.patch
http://drupal.org/files/issues/workbench_moderation-playnicewithpanels-40.patch
http://drupal.org/files/issues/workbench_moderation-preserve-history-2824798-14.patch

this combination of modules works great provided that all content types are using entity_translation (field translation) instead of content translation. Content translation does not work correctly using this setup, so we upgraded all our content types to entity_translation and it's working out well.

You can use those same patches against entity_translation 1.0
There are two related patches for entity_translation

Are you also patching core as per the drafty installation instructions or using the workaround drafty sub module?

You have admin_views installed?

Also I specified drafty beta4 not drafty beta3