Problem/motivation

Multiple PHP warnings present:

Warning: Undefined array key "retain_spacing" in Drupal\addtocal_augment\Plugin\DateAugmenter\AddToCal->configurationFields() (line 387 of modules/contrib/addtocal_augment/src/Plugin/DateAugmenter/AddToCal.php).

Warning: Undefined array key "ellipsis" in Drupal\addtocal_augment\Plugin\DateAugmenter\AddToCal->configurationFields() (line 401 of modules/contrib/addtocal_augment/src/Plugin/DateAugmenter/AddToCal.ph

Steps to reproduce

  1. Go to the display mode of the node type using this module
  2. Warnings listed at top

Proposed resolution

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.

Issue fork addtocal_augment-3418956

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mmarler created an issue. See original summary.

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !12

mrshowerman’s picture

mrshowerman
Location Munich
CreditAttribution: mrshowerman at BRANDCODE commented
Status: Active » Needs work

Left a few comments on the MR, thus changing status.

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
Status: Needs work » Fixed

Thanks for the report, the code change, and the review, everyone! This will be included in a new beta release forthwith.

mrshowerman’s picture

mrshowerman
Location Munich
CreditAttribution: mrshowerman at BRANDCODE for KultinO commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.