
Problem/Motivation
Need the config for this #3510427: Add SDDS global footer styling so going to do in this issue and the styling can happen in that issue.
Steps to reproduce
Proposed resolution
This is the footer that was designed in Figma but really anything that "looks okay" is okay:
Remaining tasks
Create a global block and update the theme config to add it to the footer.
User interface changes
User will see the footer in XB
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#9 | civictheme_loves_starshot_logo.png | 199.66 KB | kristen pol |
#7 | sdds-footer-menus-about-trademark.png | 179.34 KB | kristen pol |
#3 | sdds-footer-regions.png | 130.44 KB | kristen pol |
Issue fork demo_design_system-3511866
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Toggle MR activityComment #2
kristen polThis is similar to in terms of approach:
#3510426: Create SDDS global header config
Comment #3
kristen polThe footer regions look like this:
Comment #4
kristen polPerhaps logo in footer middle 1, footer menu in middle 2, and social links in middle 3.
There's also a trademark that can go in footer bottom 1.
Comment #5
kristen polThe logo is an svg and I can't add that via media content or ckeditor, so that will need to be handled in the css somehow.
Comment #6
kristen polWe could add a built with CivicTheme in the bottom footer too so I'll add that.
Comment #7
kristen polHere's the config/content with turns off the background color and white text.
Comment #9
kristen polStill need to figure out how to be a composite logo like:
Comment #10
kristen polI'm going to merge this but it can still be tested/reviewed by others.
Comment #12
kristen polThis and #3510426: Create SDDS global header config can be tested at the same time by using the latest dev code.
Styling will happen here #3510427: Add SDDS global footer styling
Comment #13
kristen polComment #14
gábor hojtsyHm, I think there was a misunderstanding somewhere. XB has native global region management. While that could mean moving and placing blocks in numerous footer regions, the real content creator power is in being able to adjust the footer layout as you see fit, since that is a core/key feature of XB. So #3512060: Too many global regions in SDDS is fundamental to this at first, that is for the theme to pare the regions down significantly to much simpler options. Then the user would be able to create multicolumn stuff in the footer if they so desire with XB components, columns, image components, etc. (SDDS could ship a default component setup for that region).
Building a page with components and managing global regions with components only gives user the flexibility if the global region is broad enough and not a Footer middle 3, a Footer bottom 2, etc.
Comment #15
gábor hojtsyWhen a region is configured in XB, that is saved in page region config entities, NOT as block placement entities see https://git.drupalcode.org/project/experience_builder/-/blob/0.x/docs/co...
Comment #16
kristen polYeah, when I created these, I wasn't aware of XB's global placement workflow.
Block placement has been removed and regions simplified per:
#3512657: Remove block placement of SDDS header+footer blocks
#3512060: Too many global regions in SDDS
but the content is still there. Sounds like we don't want to do the social media links for now but I'll leave the default content for now in case that changes.
Marking this one fixed and tweaks can be in the header/footer styling issues.
Comment #17
kristen pol