Steps to reproduce:
1. Go to dashboard
2. Click on "90 critical tasks" (or whatever the number is right now9
3. Link is https://drupal.org/project/issues/search/drupal?version[0]=8.x&status[0]...
4. Then you get a An illegal choice has been detected. Please contact the site administrator. error.
Looks like status and version filters don't match anymore.
Selecting 8.x and some statuses (not sure if I got the right ones, needs to be confirmed), the URl looks like this:
https://drupal.org/project/issues/search/drupal?sid%5B%5D=1&sid%5B%5D=13...
So, status => sid (apparently the same numbers) and version changed from a string (8.x) to a number.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2125037-issue_queue_version_value-9.patch | 2.58 KB | mikey_p |
| #8 | 2125037-issue_queue_version_value-6.patch | 2.12 KB | mikey_p |
Comments
Comment #1
dwwThanks, I'll look into this now. Stay tuned.
Comment #2
dwwIn D6, our magic view filter understood version GET arguments like
...&version[]=6.x&.... Now, for those magic options to show all versions for a particular "series", the actual view filter is expecting a taxonomy tid. That seems like a bug in various ways, since you could have collisions between tid integers and release node IDs. I actually think the links generated in the dashboard block should stay as they are, and we should fix the view filter to recognize the series names instead of the tids.Comment #3
arlinsandbulte commented#2125517: An illegal choice has been detected. Please contact the site administrator. seems like a duplicate of this issue, even if the link is on a different page.
Comment #4
rob c commentedNot only the dashboard is affected (obviously).
Visit: (for example)
https://drupal.org/node/1261030
The links to the queues are like:
https://drupal.org/project/issues/provision?version=7.x
While this does not work, this does:
https://drupal.org/project/issues/provision?version=103
Comment #5
tvn commentedComment #6
dwwBetter title and bumping priority. I'm not actually working on this right now.
Please note that this is an entirely separate bug from #2126853: Issue tags link to incorrect search parameter.
Comment #7
dwwEven more clear title
Comment #8
mikey_p commentedIn theory this patch to project issue should fix the problem, but I don't know how to make this work with Search API. Not sure if this will need a total index rebuild or what.
Comment #9
mikey_p commentedPrevious patch was kinda right, although it's actually against project module. This one is against project_issue and actually handles the search_api version of the view.
Comment #10
mikey_p commentedAlso, you can test this on http://dww7-drupal.redesign.devdrupal.org/project/issues/drupal?version=7.x
Comment #11
dwwYay, thanks! Code looks great. Committed and pushed:
http://drupalcode.org/project/project_issue.git/commit/b9085ec
Tested again on staging, then deployed live.
Comment #12
berdirThis only fixed part of the problem.
There is no visible error anymore, but the status conditiosn are just silently ignored now, and it lists closed issues etc. too.
Those links are supposed to have a very specific filter on those.
As written initially, here it looks ike the argument name actually changed (sid vs. status), the numbers might still be the same, not 100% sure.
Comment #13
dww@berdir: Good point, I hadn't noticed. Let's deal with that at #2128835: "Contributor Links" are not working and leave this issue for the version series filter stuff.
Thanks,
-Derek