[D7] Relation services

code style http://pareview.sh/pareview/httpgitdrupalorgsandboxrosk02141983git

Can you fix warnings from parewiew.sh

Remove "project" from the ./relation_services.info file, it will be added by drupal.org packaging automatically.
./relation_services.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function relation_endpoint_field_entity_dependencies($entity_type, $entity, $field, $instance, $langcode, $endpoints) {
./relation_resource.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function _relation_resource_create($relation_data) {
function _relation_resource_update($rid, $relation) {
function _relation_resource_index($page, $page_size) {
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
2 | WARNING | Line exceeds 80 characters; contains 91 characters
3 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------

Not sure I get #3:
Module name is relation_services
Implements hook_entity_dependencies(). means that function should be named: relation_services_entity_dependencies() not relation_endpoint_field_entity_dependencies)_

In this case you have to use hook_module_implements_alter() to inject own implementation because your module could have collision with relation_endpoint if that one will implement this.
Also doc-block should be fixed to right hook name

But the better way is to file issue to relation_endpoint module queue to implement the hook where it belongs

Except the renaming of function "relation_endpoint_field_entity_dependencies", everything looks fine.

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

• Module looks a bit short to grant you the git vetted user role, but looking at your other patches I think you know what you are doing and we can proceed.

Looks good to me otherwise! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to chx as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, RoSk0!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.