[D7] Deny Content View

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpignaz2125707git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I think this module is a great idea, but is there a difference between this module and Rabbit hole?

You should change the url to clone the project to: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/pignaz/2125707.git deny_content_view

Your url is for the maintainer.

Automated review:

There is still one error. You should delete the master branch as explained here: http://drupal.org/node/1127732

Manual review:

/**
 * Implements hook_modules_enabled().
 */
function deny_content_view_modules_enabled($modules) {

  $module = array_shift($modules);

  // Delete role permission about deny_content_view created by core.
  db_delete('role_permission')
   ->condition('module', $module)
   ->execute();
}

I think you should move this code to hook_uninstall in the .install file.

Git path updated.

You need to set the status to "needs review" if you want to get a review, see https://drupal.org/node/532400

Hi

I can´t understand why this piece of code:

/**
 * Implements hook_modules_enabled().
 */
function deny_content_view_modules_enabled($modules) {

  $module = array_shift($modules);

  // Delete role permission about deny_content_view created by core.
  db_delete('role_permission')
   ->condition('module', $module)
   ->execute();
}

I don´t understand why you are deleting the permissions set by other modules, and anyway if you want/need to do it you need to loop over the $modules array (see the code below) because is possible to enable/disable more than once module at once.

/**
 * Implements hook_modules_enabled().
 */
function deny_content_view_modules_enabled($modules) {

  foreach ($modules as $module) {
    // Delete role permission about deny_content_view created by core.
    db_delete('role_permission')
     ->condition('module', $module)
     ->execute();
  }
}

Also the .install file should be removed if it´s empty and is not providing any functionality

Best regards

https://drupal.org/project/content_access

Looks like the content access module already provides that functionality? Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please use the content access module to accomplish this use case.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Your last description of the use-case made me think of this module: https://drupal.org/project/premium_content

Is it possible this one takes care of your use-case?

No problem, you can contribute to the existing module if you want to propose any improvements or bug fixes.

Feel free to open a new project application whenever you want to promote another project.