[D7] Simple News Ticker

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrazonklnbd2075049git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

add other project review link

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

• Please adhere to the coding standards which can be found at https://drupal.org/coding-standards. Let me give you a hint: 2 spaces of indentation.
• Remove the following lines from the .info file, they are not needed.
  ; $Id: simpleticker.info$
  version = 1.0
  files[] = simpleticker.module
  package = others

Also, install Coder module and fix the issues it reports.

Best of luck!

Change name of project on git from 2075049 to simple_news_ticker

General

• For easily clone the project, it would be great if you could specify the clone URL as
  git clone --branch 7.x-1.x http://git.drupal.org/sandbox/razonklnbd/2075049.git simpleticker
• Use coder module and review your code.

Manual Review

Readme.txt

• Include Readme.txt in your project, so one can easily use this project. Refer https://drupal.org/node/7765 for best practices.

simpleticker.info

• Refer https://drupal.org/node/542202 to write module .info file in D7
• Line # 1 : Remove line
  ; $Id: simpleticker.info$
• Line # 3 : Update the description and add more specif to your module functionality.
  ; $Id: simpleticker.info$
• Line # 4 : Remove line
  version = 1.0
• Line # 6 : Remove line
  files[] = simpleticker.module
• Line # 10 : Remove line
  package = others
• Include Block module dependency in your code.
  dependencies[] = block
• Remove unwanted new lines
• Prefer to add js and css in .info file using the scripts tag instead of .module hooks, to add the css and js to every page. Refer https://drupal.org/node/171213 and https://drupal.org/node/171209
  

  ; Always available JavaScripts 
  scripts[] = fade.js

  ; Always available CSS
  stylesheets[all][] = simpleticker.css

simpleticker.module

• Get "The block Ticker block was assigned to the invalid region spticker and has been disabled." warning mesage, if we enable the module. Check line # 73 in simpleticker_block_info() function.
• Get PDOException error, if we assign Ticker Block to a region, say content. See attached image.
  
  Check line # 89 in simpleticker_block_view() function.
• Prefer to add js and css in .info file and remove the preprocess_html hook from .module file. Refer https://drupal.org/node/171213 and https://drupal.org/node/171209
• Remove unused/commented code from file.

Hi there,

I did a manual review of your code and found the following issues. See below:

LINE 73: 'region'=>'spticker'...
Looks like you are trying to assign newly created block to a region named 'spticker'. Not everyone will have a 'spticker' region in their drupal installation. Please assign it to region that is common with most drupal installations or just leave it unassigned.

LINE 89: $sql2select='select n.nid, n.title, n.created...
The query doesn't look right to me. It looks like you have added some custom fields to your node type and your query is dependent on those fields. Again, not everyone will have exactly the same setup of content type as yours so this needs to be changed.

You can either make your module to create a new content type and add those fields (This requires creating a installation script for your module) and that way you can make sure that those fields are there.
OR
Just base your query on standard drupal fields. For example all the modules which have been promoted as sticky will be added to ticker...

Let me know if you need any help...

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.