[D7] Taxon Taxonomy

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please tell us how we can enable Taxon and Taxon web service to test your project. Please write as details as possible.

But I installed your module in my test-box and found no problem. But I really don't know what is its work. Need document link of usability.

Thanks.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).

Can you confirm that the Taxon account is a single user? Please change your account information and enter your realname.

If you prefer, we can also promote this sandbox to a full project without granting you "git vetted user" status.

License

Please remove the LICENSE.txt file. Drupal will add the appropriate version automatically during packaging so your repository should not include it.

PAReview: 3rd party code

taxon_taxonomy.js appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

• You should only have 1 branch in your drupal repository, named 7.x-2.x. Individual releases can be tagged from that branch. My review is based on the 7.x-2.2 branch. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
• Remove the .gitignore file from the repo
• Use a default value when calling variable_get, like variable_get('taxon_taxonomy_number_results_returned', 5);. This will return 5 even if the variable has not been explicitly set yet.
• In _taxon_taxonomy_proxy() I think you are trying to remove html tags from the text, can you use strip_tags() instead of all the regexes?
• When you are generating the string for POST, http_build_query() might be easier than creating it yourself.
• If your module requires curl to work, implement a hook_requirements() to make sure it's installed, or consider switching to drupal_http_request().
• For returning json output, use drupal_json_return()
• Instead of using hook_init(), which is called for every Drupal page request, can you instead only load your js/css where they are actually used?
• Why do you require ckeditor?

----
Top Shelf Modules - Crafted, Curated, Contributed.

added link to project page

Project page

Please take a moment to make your project page follow tips for a great project page.

I think you still need to remove the license/copyright text from taxon_taxonomy.js, or get an exception to Drupal's standard rule against hosting licensed code.

Otherwise looks ready to go!

----
Top Shelf Modules - Crafted, Curated, Contributed.

Hi Brian,

Congratulation for the module! I already use it for some of projects that I work on.

I just want to suggest you 2 small improvements:
- it is not needed to use a custom submit callback function(taxon_taxonomy_admin_form_submit) for the admin form. Use system_settings_form instead of it.

- in your ajax call you've hardcoded the basepath in ajax url ""/taxon-taxonomy". Also this will make your ajax call to use only the default language.
You could use Drupal.settings.basePath and Drupal.settings.pathPrefix to handle them.

@Taxon - you don't need to set this back to "needs review" - once it's in RTBC, it's only 1 review away from being published!

@boyan.borisov - those are great suggestions, but "needs work" is only for major blocking issues.

Hi Taxon,

I guess that if you want to speed up the publishing of your module you should become part from the review bonus program.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Taxon!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.