[D7] Instance settings

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxaroq2134613git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I am not certain this is different from exporting field settings with Features. Perhaps you want to clarify how this is different.

This is a really cool idea and I'm excited to review it. Your automated testing is only showing a few minor format errors. Once those have been cleared you can move it and get some more eyes on it.

One thing I saw was a error message being returned that had now details. Not very useful.

Thanks,
Dan

instance_settings_modules_enabled() is quite hard to follow. Could probably use some inline comments as it would be hard for the next developer to figure out what's going on.

instance_settings_module_enable(), instance_settings_apply() and instance_settings_module_disable() misses both @parm and @return in the function documentation.

When creating links consider whether l() could be a better alternative than url() in instance_settings_init().

@aroq That is true. And makes totally sense. Maybe the description could be a bit more describing? For instance_settings_module_enable() it could for example be something like

Enables an array of modules and returns TRUE if something need rebuilding

manual review:

1. instance_settings_init(): The @link will be broken since you use the "@"placeholder which will run check_plain() for you and escape the link markup. Use the "!" placeholder instead.
2. "module_invoke_all('instance_settings_apply');": Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php
3. I don't understand what a module pool is? Please provide a better example in the README, where is feature_environment_local used? What modules are in that pool? What is the difference to feature_environment_prod? A "pool" usually means a list, a collection, an array. But in your case it seems that a pool is only one module? Why do you you call it pool then and not instance module or similar?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

You might want to create a documentation page for your project here:
https://drupal.org/documentation/modules/contributions
(Bottom of the page "Add child page")
And link to it from your project page links on the right side bar.
(I personally don't like reading large text README's very much.)

Your commit messages could have a little more detail (describe why and what has changed) but that's always hard at the beginning.

The description in your .info file would be more useful if it would be an actual description; otherwise you can just remove it.

But this is just nitpick, therefore..

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.