Description

Context callback, a small module that enables developers to easily add callback functions that can trigger contexts (see the context module).

Project page

https://drupal.org/sandbox/spadxiii/2130755

Git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/SpadXIII/2130755.git context_callback

Reviews of other projects

Session node access
Simple Weather
One time login password

CommentFileSizeAuthor
#13 issue.png15.47 KBnitesh sethia

Comments

mindewen’s picture

mindewen commented

Please update the .info file to follow the coding standards.
It should be dependencies[] not depends.

mindewen’s picture

mindewen commented

Please update the .info file to follow the coding standards.
It should be dependencies[] not depends.

spadxiii’s picture

spadxiii commented
Status: Active » Needs review

Updated the .info file. Not sure why I missed that.

davidpetit’s picture

davidpetit commented

Hi ! I think you could add some documentation on how to use this module with some example.
Maybe you could add this in the api.php file or in a README.txt file ?

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxSpadXIII2130755git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

spadxiii’s picture

spadxiii commented

Added a README.txt with some more information and example code.
Also changed the code and comments a bit to please the PA robot :)

spadxiii’s picture

spadxiii commented
Status: Needs work » Needs review
aroq’s picture

aroq commented

Probably it will be better to update description to make things clearer:

1. update git information into git clone --branch 7.x-1.x http://git.drupal.org/sandbox/SpadXIII/2130755.git context_callback
In this way reviewers can clone the project with copy/paste.

2. provide a link to Context module, to make sure users don't mix it up with ctools contexts.

spadxiii’s picture

spadxiii commented
Issue summary: View changes

As suggested: I updated the summary and project page with a better git-link and a link to the context module.

fusionx1’s picture

fusionx1 commented

I just installed and hooked it into my module, functionality it works ok, but would be delighted if you can also explain or add it in your README your future plans on what other plugins can be supported by context_callback. I think this module has a lot potential.

spadxiii’s picture

spadxiii commented

@fusionx1 : what kind of plugins are you thinking of?

As for future plans: I have started a different sandbox with a module 'functional content' which uses this module. Functional content is a module that wraps nodes around views blocks. So instead of making a view with a fixed title, uri, etc., you create a view block, enable the functional content for this view block and then content editors to easily edit the node that 'wraps around' the view block.

jmaerckaert’s picture

jmaerckaert commented

I installed and hooked it into my module.
It works has expected but maybe a php textarea in context condition would be beter to directly insert code.

Regards.

nitesh sethia’s picture

nitesh sethia commented
Status: Needs review » Needs work
StatusFileSize
new issue.png15.47 KB

@spadxiii

I have tested your module. Things are working fine but try to remove the error being highlighted in the attachment.
issue

nitesh sethia’s picture

nitesh sethia commented
Status: Needs work » Needs review

Its not a blocker so changing the issue status.

spadxiii’s picture

spadxiii commented

@Nitesh I can't rename that function, because it comes from the class context_condition in the context module :(

ericclaeren’s picture

ericclaeren commented

Looking good. Haven't found any issues, the camelCase error isn't fixable due to context.

@jmaerckaert A php textarea, doesn't sound like a good idea, security wise.
Think the current functionality fits the needs of this module.

ericclaeren’s picture

ericclaeren commented
Status: Needs review » Reviewed & tested by the community
spadxiii’s picture

spadxiii commented

so, what's the next step in converting my sandbox into a project??

spadxiii’s picture

spadxiii commented
Issue summary: View changes
spadxiii’s picture

spadxiii commented
Issue summary: View changes
mraichelson’s picture

mraichelson commented

so, what's the next step in converting my sandbox into a project??

Once it's RTBC it's just a matter of waiting for review by the powers that be. (Looks to be about a week+ that they let stuff sit as RTBC to see if any other reviewers find anything.)

spadxiii’s picture

spadxiii commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

manual review:

  1. project page: why should I use this module? I can just write my own context condition plugin? Please explain the difference on the project page.
  2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

But otherwise looks good to me, so ...

Thanks for your contribution, SpadXIII!

I promoted the project for you: https://drupal.org/project/context_callback

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.