Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Description
Context callback, a small module that enables developers to easily add callback functions that can trigger contexts (see the context module).
Project page
https://drupal.org/sandbox/spadxiii/2130755
Git
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/SpadXIII/2130755.git context_callback
Reviews of other projects
Comment | File | Size | Author |
---|---|---|---|
#13 | issue.png | 15.47 KB | Nitesh Sethia |
Comments
Comment #1
Mindewen CreditAttribution: Mindewen commentedPlease update the .info file to follow the coding standards.
It should be dependencies[] not depends.
Comment #2
Mindewen CreditAttribution: Mindewen commentedPlease update the .info file to follow the coding standards.
It should be dependencies[] not depends.
Comment #3
SpadXIII CreditAttribution: SpadXIII commentedUpdated the .info file. Not sure why I missed that.
Comment #4
DavidPetit CreditAttribution: DavidPetit commentedHi ! I think you could add some documentation on how to use this module with some example.
Maybe you could add this in the api.php file or in a README.txt file ?
Comment #5
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxSpadXIII2130755git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
SpadXIII CreditAttribution: SpadXIII commentedAdded a README.txt with some more information and example code.
Also changed the code and comments a bit to please the PA robot :)
Comment #7
SpadXIII CreditAttribution: SpadXIII commentedComment #8
aroq CreditAttribution: aroq commentedProbably it will be better to update description to make things clearer:
1. update git information into
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/SpadXIII/2130755.git context_callback
In this way reviewers can clone the project with copy/paste.
2. provide a link to Context module, to make sure users don't mix it up with ctools contexts.
Comment #9
SpadXIII CreditAttribution: SpadXIII commentedAs suggested: I updated the summary and project page with a better git-link and a link to the context module.
Comment #10
fusionx1 CreditAttribution: fusionx1 commentedI just installed and hooked it into my module, functionality it works ok, but would be delighted if you can also explain or add it in your README your future plans on what other plugins can be supported by context_callback. I think this module has a lot potential.
Comment #11
SpadXIII CreditAttribution: SpadXIII commented@fusionx1 : what kind of plugins are you thinking of?
As for future plans: I have started a different sandbox with a module 'functional content' which uses this module. Functional content is a module that wraps nodes around views blocks. So instead of making a view with a fixed title, uri, etc., you create a view block, enable the functional content for this view block and then content editors to easily edit the node that 'wraps around' the view block.
Comment #12
jmaerckaert CreditAttribution: jmaerckaert commentedI installed and hooked it into my module.
It works has expected but maybe a php textarea in context condition would be beter to directly insert code.
Regards.
Comment #13
Nitesh Sethia CreditAttribution: Nitesh Sethia commented@spadxiii
I have tested your module. Things are working fine but try to remove the error being highlighted in the attachment.
Comment #14
Nitesh Sethia CreditAttribution: Nitesh Sethia commentedIts not a blocker so changing the issue status.
Comment #15
SpadXIII CreditAttribution: SpadXIII commented@Nitesh I can't rename that function, because it comes from the class context_condition in the context module :(
Comment #16
ericclaeren CreditAttribution: ericclaeren commentedLooking good. Haven't found any issues, the camelCase error isn't fixable due to context.
@jmaerckaert A php textarea, doesn't sound like a good idea, security wise.
Think the current functionality fits the needs of this module.
Comment #17
ericclaeren CreditAttribution: ericclaeren commentedComment #18
SpadXIII CreditAttribution: SpadXIII commentedso, what's the next step in converting my sandbox into a project??
Comment #19
SpadXIII CreditAttribution: SpadXIII commentedComment #20
SpadXIII CreditAttribution: SpadXIII commentedComment #21
mraichelson CreditAttribution: mraichelson commentedOnce it's RTBC it's just a matter of waiting for review by the powers that be. (Looks to be about a week+ that they let stuff sit as RTBC to see if any other reviewers find anything.)
Comment #22
SpadXIII CreditAttribution: SpadXIII commentedComment #23
klausimanual review:
But otherwise looks good to me, so ...
Thanks for your contribution, SpadXIII!
I promoted the project for you: https://drupal.org/project/context_callback
Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.