[D7] Nepali calendar

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpachabhaiya2165233git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Dear c.pachabhaiya ,

Findings of manual review.

A minor change,

You can directly use t function instead of get_t() in install and uninstall hooks.

Please find more details below.

1. Use t() if your code will never run during the Drupal installation phase.

2 . get_t() should be used if your module is part of Drupal Core Installation.

* No need of nepali_calendar_admin_settings_form_submit function. When you use system_settings_form it will take care of field values set. For more info https://api.drupal.org/api/drupal/modules%21system%21system.module/funct...

Cheers,
Anil Sagar

Cheers,
Anil Sagar

Hi c.pachabhaiya,

I think it would be recommended to move the function nepali_calendar_admin_settings_form in a separate file, called nepali_calendar.admin.inc, different from the module file (which loads on every page), which would slightly lower the memory footprint of the module.

Cheers.

manual review:

1. nepali_calendar_install(): no need to set variables in hook_install() as you can make use of default values with variable_get() anyway.
2. "case 0:{": the curly braces around case statements are not necessary, see https://drupal.org/coding-standards#controlstruct
3. nepali_calendar_ad_to_bs(): what is this large $bs array? Why can't it be generated and needs to be hard coded on 130 lines of code? Please add a comment and a reference where this comes form.

But that are not application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

I ran this this project through preview.sh there were a 9 errors found

http://pareview.sh/pareview/httpgitdrupalorgsandboxpachabhaiya2165233git

they all say "Case breaking statements must be followed by a single blank line"

no other objections for more than a week, so ...

Thanks for your contribution, c.pachabhaiya!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.