[D7] Pines Notify

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxzhuber2169043git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi

Thanks for your contribution, I've reviewed your module and found the following issues:

1. Switching the module on breaks the permissions page.

2. Configuration links isn't showing up on the modules page.

3. The inserted javascript should probably follow the function definition defined in https://drupal.org/node/172169#functions

Apart from that, it looks to be working just fine.

Thank you

Michel

I just installed this module and can confirm that the mentioned issues are now fixed.

The drush command to install the library works like a charm.
Some proposed enhancement: You could add some sort of library detector that will add some info at the status report page. The Chosen module adds something like this in it's settings form:

  $chosen_path = chosen_get_chosen_path();
  if ($chosen_path) {
    ...
  }
  else {
    $form['chosen']['chosen_library_missing'] = array(
      '#markup' => t('The library could not be detected. You need to download the !chosen and extract the entire contents of the archive into the %path directory on your server.', array('!chosen' => l(t('Chosen JavaScript file'), CHOSEN_WEBSITE_URL), '%path' => 'sites/all/libraries')),
    );
  }

Anyway, maybe this is more nice to have.
Thanks!

manual review:

1. pines_notify_uninstall(): DELETE in db_query() is forbidden in D7, you must use db_delete() instead, see https://drupal.org/node/310081 . In this case you should rather use explicit variable_del() calls instead.
2. pines_notify_init(): why do you use hook_init()? It does not make sense to setup the JS stuff for drush invocations for example? You should rather use hook_page_build() so that the code is only executed when an actual HTML page is returned. See https://api.drupal.org/api/drupal/modules!system!system.api.php/function...
3. theme_pines_notify(): instead of repeating jQuery(document).ready() you should add the messages to Drupal.settings and then print them with some Drupal.behaviors callback. See also https://drupal.org/node/756722 . Seems like that should be done in pines_notify.js
4. pines_notify.drush.inc: is that really necessary? You could just use drush make with an example make file for downloading the library.

Although you should definitely fix those issue they are not critical application blockers, so ...

Thanks for your contribution, zhuber!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.