[D7] Twitter Hashtag

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxElAlemanyo2102283git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi El Alemaño,

To get the regular stuff out of the way:
- Instead of the "master" branch your branch naming should allow for easy recognition of compatibility. 7.x-1.x is recommended. See https://drupal.org/node/1015226
- fix up the issues reported by PAReview
- check out these tips for a template on what a good project page looks like.

Manual review:
- Installation - ok.
- Configuration steps: ok
- When I create a piece of content and use the tag "jailbreak" or any other tag I just see an animated bird and a "Load More" link.

- I see you have two files named twitter_hashtag.js. Is this necessary?
- Only the opening <?php tag is required in a PHP-only file. See PHP Tags documentation.
- You define a lot of markup in _twitter_hashtag_load_tweets. Would it be possible to move all this markup to a template file and utilize the theme layer.

Hi

I think this is a useful feature. I would like to offer my help and can work as a maintainer to fix the issues in the module. I have a good understanding of social media APIs.

Regards,
Parul

Hi,

I checked the code as it seems that its connected to node type selection and should do something like finding the given hashtag into the node content but its just using a plain fetching of hashtag based twitter results.

There is another module which already does the same thing.
https://drupal.org/project/twitter

What is other than that you are doing differently.

Thanks

Hi El Alemaño

I agree with Divesh, that the as of now your module is doing the same work as the twitter module.

I would like to help you get this module out of sandbox, but for that we will have to think of some new feature to add to this module, so that it has some extra useful funtionality other then twitter module (https://drupal.org/project/twitter), and also fix the existing coding standard bugs. If you can make me the co- maintainer, I can start fixing some of the bugs.

Thanks
Parul

Hi

As mentioned in the first comment by PARobot, you need to fix the bugs mentioned at this link: or install the coder module and code sniffer module at your end, fix the bugs or warnings reported by the module.
If you provide me the git access then i will also fix some of them.

Once this is done, you will need so that your module comes in high priority list for review, or people in the community pick the module with the review tag early. So to make the process faster, try getting the review bonus tag, side by side.

Please update,when you provide me the access, so that i can start fixing some issues along with you.

Thanks
Parul

Also twitter module fetches the tweets using twitter handle, not the hash tags, like your module. I have used your module and tried using it, its working fine. But will update if I find bugs while using it at other pages on the site.

Thanks
Parul

Hi

I tried commiting some of the fixes mentioned by the pareview, but when pushing the changes to the repository , i got error. I think I still dont have the rights. You will have to add me as maintainer, and give me rights by selecting the checkboxes.
I tried twice, i got permission denied error.

Also will share my skype ID soon.

Thanks
Parul

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@El Alemaño, thank you for your contribution.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. Yes http://pareview.sh/pareview/httpgitdrupalorgsandboxelalemanyo2102283git reported number of issues that need to be fix.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

(*) Maybe: Does not cause module duplication and fragmentation. Can you follow the steps in the link and confirm that the functionality contained in this module should stay separate from Twitter? Also list out similar module on your project page and show the differences how your module is different from others.

Master Branch

(*) No: Follows the guidelines for master branch. You should delete your master branch, according to https://drupal.org/empty-git-master and change your git clone URL with 7.x-1.x branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No. If "no", list security issues identified.

• _twitter_hashtag_load_tweets: this is also vulnerable to XSS. twitter_hashtag_lang variable comes form user provided input, so you need to sanitize it before passing further, make sure to read https://www.drupal.org/node/28984 again. I notices other variables also using without sanitize that need to be fix.

Coding style & Drupal API usage

1. (+) twitter_hashtag_init(): You are adding twitter_hashtag.js and twitter_hashtag.css here. Due to this, both will added on all the pages rather use #attached to add the JS/CSS file to the form render array or page render array where these actually required.
2. (+) Instead of using time(), should use REQUEST_TIME.
3. _twitter_hashtag_load_tweets(): Instead of using json_decode(), should use drupal_json_decode().
4. twitter_hashtag_block.tpl.php: you are using php short tag <? ?>, better to make consistency.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Thanks again for your hard work!

If you are done with your changes then please switch status from Need Work to Need Review.

Removing review bonus tag, you have not listed any reviews in the issue summary. Make sure to read the docs again: http://drupal.org/node/1975228

Update git clone command with that in comment #16.

Automated Review

Automated project review returns many errors to be fixed in the code, remove license and others.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
(*) Seems there is a product duplicating functionality (https://www.drupal.org/project/twitter), but your design seems better.
I am not able to check all other issues as git asks for a password while retrieving the files, so you should upgrae your git command too

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.