[D7] Views Selective Filter

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdavid_garcia_garcia21...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi David,

Please make sure that the lines in your README are no more than 80 characters in length, just to keep in line with the coding standards.

I'd agree that the other errors can likely be ignored as, like you say, you are overriding existing methods.

Cheers,
Adam

I'm currently using HEAD from 1/10 with no issues. Everything works as desired.

Docblock should be immediately above views_handler_filter_selective in file views_handler_filter_selective.inc.

class views_handler_filter_selective extends views_handler_filter_in_operator {

See the API documentation - http://drupal.org/node/1354#classes

Line number 196 : Missing comma at the end of the last array element in views_handler_filter_selective.inc.

i'm using the module in production in the context of a huge conference page ...
had some minor bugs and david fixed them immediately ...
great module and now everything works as desired ...
so +1 for a real project ...

This is a great module and works much better then the one in the view_hacks module. Just began testing this module and so far it was works as intended.

Another +1 for a real project.

I'm having issues with a 2nd site. This module seems to be dropping some of the terms. On another view it drops terms and a couple show up out of order.

I'm using head from 2/2/2014

@xl_cheese: You should create a issue in the project's issue queue.

david, still there are some issues reported by pareview. http://pareview.sh/pareview/httpgitdrupalorgsandboxdavidgarciagarcia2162...

Minor coding standard issues are not application blockers, please do a real manual review.

@klausi, i was performing a manual review in the mean time i posted PAReview's result. Thanks for pointing out. Point noted.

@david_garcia_garcia, thanks for clarification. So far i did not notice any issue in my manual review.

Works great with patch to Views core applied.

Hy,
Thanks for the sandbox project. Works like a charm and a good replacement to the one included in views hack.
However I ve a question, what if my use case is a view where I want to show content (teaser for ex) and not fields.
In that case the module won't work.
am I rigth ? Any plans to provide a solution for this case ?
THanks

Thanks
Hoping this feature makes it at some point.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. views_filters_selective_init(): why do you need hook_init()? It does not make sense to add your javascript on drush invocations for example? Why can't you use some Views hook when an actual view is displayed?
2. views_filters_selective_handler_filter(): this function does not do anything? Just return $oids as is, what's the point of the loop?
3. views_handler_filter_selective.inc: @inheritdoc is only allowed on methods, please document this class.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to MiSc as he might have time take a final look at this.

I tried this sandbox version on the 22nd of April in Drupal 7 and it worked wonderfully! Really wish there was a link to this sandbox from the Views Hacks module...

Because the instructions on the Views Hacks module itself are misleading (even for the version that is currently available on Views Hacks), I created a writeup of how I use it here: http://from-the-design-table.tumblr.com/post/83540183502/how-to-views-se...

So far, I haven't run into any issues with it at all.

Edit: Small bug. When you haven't yet added a corresponding field in the view, the error reminding you to do so displays twice.

no objections for more than a week, so ...

Thanks for your contribution, david_garcia_garcia!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Great little module. Installed and worked as described. However, I wanted to request a feature for this module:

(Note: I am modifying my original post as I now have a better understanding of the exposed filter settings in views)

In my setup, I am using a taxonomy as my exposed filter and the "required" check box is necessary for what I want to accomplish. Basically, I need one of the terms to be selected by default. Default in views exposed filters is handled by always selecting the top term in the list. The problem is that this module is re-sorting the terms alphanumerically instead of the order in which they are saved in the term list. There needs to be a way to sort the terms in the select list, or to preserve the order that is set in taxonomy.