[D7] Webform Confirmation

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

webform_confirmation_uninstall(): uninstalling the schema is not necessary in drupal 7, so this function should be removed.

You should also be handling the case where in the user clicks on the confirmation link for the second time inside function webform_submission_approve().

Also, providing a configuration to redirect the user to a custom page after clicking on the link would be good feature to have.

@Nitesh Sethia
Can you please delete master branch and port it on 7.x-1.x.
And I have also find some unused variable and notice which you can refer from here:-
http://pareview.sh/pareview/httpgitdrupalorgsandboxnitesh112141847git

Hi, @Nitesh Sethia

• Why do you use 'varchar' type for ID numbers in hook_schema?
• Instead of curl library you may use drupal_hhtp_request().
• It's recommended to move all page callbacks to .pages.inc files.

Hi Nitesh,
I was testing your module and I really appreciate that you have created this kind of sub-module of Webform.
But I find one small bug which you can solve by just putting below code:-

function hook_uninstall(){
  variable_del('YOUR_VARIABLE_NAME');
}

It will help you in deleting variable when uninstalling module.

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Your module looks really good.

In webform_confirmation.module on lines 140 and 141, you are using $_GET. Is there any reason you aren't using the API function arg?

https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/arg/7

Review of the 7.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/webform_confirmation.module
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   121 | WARNING | Messages are user facing text and must run through t() for
       |         | translation
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. project page: "On clicking on the confirmation link in the email, the user confirms that he is not a spammer." please don't assume that users are male.
2. "variable_del('bit_ly_information');": all variables used by your module need to be prefixed with your module's name to avoid names collisions.
3. webform_confirmation_permission(): permissions are usually all lower case.
4. webform_confirmation_menu(): "verify" is a it short as menu entry and people might want to use that for something else, so I guess you should prefix that menu path with something specific to your module. Or even make it configurable.
5. webform_confirmation_confirming_verification(): this will not scale. Why do you fetch the whole table content? You should use conditions on the query to only get relevant results, than you don't have to iterate over possibly thousands of records.
6. " 'help' => 'Mydons Custom database table',": what is Mydons?
7. webform_confirmation_submit(): don't use md5() for security tokens, use drupal_random_bytes() or drupal_hmac_base64().

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to MiSc as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, Nitesh Sethia!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Closing this application as its been fixed & respective account has been updated

No need to do that, fixed issues will close automatically after 2 weeks. This gives interested parties time to reactivate the issue if they see a problem with the fix and also allows time to see that a change has been made. See https://drupal.org/node/156119