[D7] Facebook Embed

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxvalkum2114399git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review:

I have found some problems when I have installed the module, those are as follows:

1. After install the module the configure link doesn't work from module listing page. This is because you put the wrong URL for configure in the .info file. Correct URL will be configure = admin/structure/facebook_embed
2. It adds the FBJS before end of the body tag but it doesn't works. I have added the FBJS within the post then it works.
3. Readme file is very simple, please try to add more details. Please try to mention to enable your filter in the text formats. Mention this in installation process or configuration section of your readme file
4. In configuration page on admin section there is an error message showing. There was in issue with fetching Facebooks locales. Please try again later. I do not understand why this shows and what to do. Please clarify this in you message or readme file or in help section.
5. Is it possible to show a loading image or something when post is loading? I think you can put the loading image inside the div which is rendered by your filter. This will be replaced by FBJS when the post is placed.

There are very few minor issues here reported the automated review tool, please see here: http://pareview.sh/pareview/httpgitdrupalorgsandboxvalkum2114399git and try to fix them.

Everything else looks very fine to me. If there is no existing module like this then it is good one.

Thanks

Shrinked images.

Reviewed the module using coder & Grammar Parser

Error report shows -

facebook_embed.admin.inc

severity: criticalreview: security_fapi_title
Line 25: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_fapi_title]
      '#title' => 'Mapping for ' . check_plain($language->name) . ' (' . check_plain($language->language) . ')',

This can be fixed using attached patch [security_fapi_title-2114771.patch]. Otherwise code looks clean.

Hey valkum,

I really like Facebook Embed, well done! Just a few points I think should be done before you release it:

1. As pointed out by neerajskydiver in #6, there is an issue with the title in the admin interface. Always use the t() function in printed text, so you module can be localized to other languages and it even checks the output for security vulnerabilities for you! You can solve this by changing it to '#title' => t('Mapping for @language_name (@language_language', array('@language_name' => $language->name, '@language_language' => $language->language)),
2. Your filter should be more explicit about its functionality. Take for example Video Filter: 'Substitutes [video:URL] with embedded HTML.'. I suggest changing 'This input filter allows users to drop in links to public facebook posts and have them automatically transformed into an Embedded Post.' to 'Substitutes [facebook_embed=URL] into an Embedded Post.'
3. There is no feedback for editors how to use the filter. Can you add a formatting instruction with callback_filter_tips

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Otherwise looks pretty good. The fb_social check is a little odd, but I assume it works.

----
Top Shelf Modules - Crafted, Curated, Contributed.

See no 6 at Moving from a master branch to a version branch. So better you remove the master branch from your repo. And be sure you've set the appropriate default branch as directed before you delete master entirely.

• You should remove the master branch, it's not needed anymore.
• If the screenshot is outdated, can you post a correct one?
• That facebook_embed_page_alter() is pretty ugly - could you use the Libraries API instead to make sure the library is loaded? Or a hook_requirements() to see if it's present? Generally modules try to have a local version of the js library, so it can be compressed and aggregated, as well as preventing another http request to FB.

None of those are blocking issues though, and it's been more than a month without any problems reported.

Thanks for your contribution, valkum!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Hello,
I think I didn't forget anything, but here is what i get with :
[facebook_embed=https://www.facebook.com/xxx/posts/xxxx]

as i am using CKEditor:
- nothing with "plain text" or "filtered HTML" or "Full HTML" when I activate "Facebook Embed Filter " (other filters disactivated)
- [facebook_embed=https://www.facebook.com/xxx/posts/xxxx] when "Facebook Embed Filter " is disactivated

Hi,

I am trying to make this module work. In the example image above, the body shows a URL for a facebook posting. I don't understand where that code comes from. I have a bunch of data that I want to re-post from FB. If I visit a certain group's page, there are many postings of course, so I never see a URL as indicated above.

I've also been trying to get Facebook's embed code to work--I found the URL in the embed code and stripped out everything else. Then I structured it as in the image above:

[facebook_embed:https://www.facebook.com/photo.php?fbid=630580583646202]

AND

[facebook_embed:https://www.facebook.com/photo.php?fbid=630580583646202&set=a.1354666498..." data-width="466"]

Neither one works for me.

I am so happy to find this module as it was exactly what I was looking for--if I can get it to work for me.

Thanks!

Update:

I neglected to say what I mean by 'doesn't work'. It just displays the embed code from the posting or, depending on which filter I choose, will display nothing.

Then, in configuration/text formats I found a 'Facebook Embed' filter. I was overjoyed, and went back to the node, and chose "embed filter" from the dropdown (instead of filtered or html) but I still got the same result.

The best result I got was with 'filtered html' which showed a link back to the facebook group who posted the content, but it didn't actually show the content itself.

I would be so grateful for some advice. This would be a lifesaver for my website. Thanks!