[D7] Views book

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

For some reason I couldn't get the parreview.sh review to work properly, so I don't have the output but I did notice that there are some issues in your code most notably lines that are no longer than 80 characters (in all of your files).

You mention only supporting block displays in the code but I think it would make the module somewhat more useful and likely wouldn't take much work to add support for view content panes.

When I clone your repo and look at the code I see many lines over 80 characters. Here's a screenshot of your .module file. Ignore the over80info.png I uploaded the wrong file.

Site builders using panels may wish to use the pane display rather than using a block display.

Yeah pane support certainly isn't a requirement as panels users could still use the block display, I would be fine with this module being granted full project status without it. The link lengths look great for the info and readme files. For the module file, most of them have been cleaned up but the following lines go over 80 characters:
49
54
76
82
100
113
120
121
122
123
133
139
195
196
197
210

If you feel that they should stay at is then it works for me, I just wanted to make sure they weren't an oversight. Looks good.

I have performed some tests in this module, and I found some suggestions:

1. The same "Book outline" form also exists in the node/%nid/outline page. I saw that you are only doing the form alter in the "book_node_form", but the "book_outline_form" probably also needs this same form alter.
2. The option "<create a new book>" is not available when I am editing the content.
3. You could create a views in your module using hook_views_default_views(), so the user who install this module do not need to create a views from scratch, they only need to customize it.
4. "Select a display" field does not come with the value I have previously selected on admin/content/book/settings. This PHP notice is showing:
   

   Notice: Undefined index: values in viewsbook_form_alter() (line 72 of /var/www/drupal7/sites/all/modules/contrib/views_book/viewsbook.module).
          

Manual Review:

• lines 16 and 112: Line breaks inside the t() function makes the translation of the strings a little bit strange (I know that they will have more than 80 chars, but in this case, I think it is OK).
• You could add t() in the line 53 like in the example bellow:
  

  $form['book_viewsbook']['book_viewsbook_error'] = array(
    '#markup' => "<div id='message'><div class='messages error'>" .
    t('No node views are available. Please create a view of type node and a block display for it.') .
    "</div></div>",
  );
  

Please view http://pareview.sh/pareview/httpgitdrupalorgsandboxgalindus2182941git and fix all the errors.

Tip for fixing "Whitespace found at end of line" error:
Using regular expressions, you can:
replace " *\n *?"
with "\n"

This converts all white spaces to new lines.
Or you can delete them by hand.

Additionally, I do not see why a markdown syntax is necessary for a README file.
The standard is README.txt (not README.md) https://drupal.org/node/447604. Please change.

Regards,
imgio

https://drupal.org/project/views_book_chapter

This sounds like a feature that should live in the existing views_book_chapter project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the views_book_chapter issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

I'm the maintainer of views_book_chapter.

And I don't see any relation (jus the name "views") But this module help in the admin content, to easly see and help the editor to see which book exist and more simply to select.

https://drupal.org/project/book_helper
https://drupal.org/project/book_made_simple

This modules have more relation.

Anyway looks good the module.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.