1. Description
'User Trend' module helps in tracking the user login trend. You can select the 'From Year' & 'To Year', this module will show you the count of users 'logged in' during that period in a group by fashion. It breaks down the login trend in Yearly, Quarterly, Monthly, Weekly and Daily Trend.
Unlike other modules for maintaining user login count like 'User Stats', 'User Trend' is independent of 'how many times a particular user logged in'. It shows 'how many unique users logged in during a particular period'.
2. Features
1. Report for Yearly Trend user login.
2. Report for Quarterly Trend user login.
3. Report for Monthly Trend user login.
4. Report for Weekly Trend user login.
5. Report for Daily Trend user login.
3. Project page
https://drupal.org/sandbox/babruix/2179981
4. Git link
git clone --branch master babruix@git.drupal.org:sandbox/babruix/2179981.git
5. Reviews
Not yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | strict_warning2.png | 27.87 KB | Rkumar |
| #4 | strict_warning1.png | 27.64 KB | Rkumar |
Comments
Comment #1
mehul.shah commentedThere are some errors & warnings reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbabruix2179981git
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
tr commentedBased on #1
Comment #4
Rkumar commentedHi,
Please fix them,
1. By Coder
File: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_camel_caseLine 170: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray = _get_quarter_period($var_quarter, $var_year);
severity: normalreview: style_camel_caseLine 171: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varFromTimestamp = $quarterArray['start'];
severity: normalreview: style_camel_caseLine 172: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varToTimestamp = $quarterArray['end'];
severity: normalreview: style_camel_caseLine 181: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
array(':from' => $varFromTimestamp, 'to' => $varToTimestamp))
severity: normalreview: style_camel_caseLine 285: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varFromTimestamp = strtotime($var_from_year . '-' . $var_from_mon . '-'
severity: normalreview: style_camel_caseLine 287: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varToTimestamp = strtotime($var_to_year . '-' . $var_to_mon . '-'
severity: normalreview: style_camel_caseLine 297: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
array(':from' => $varFromTimestamp, 'to' => $varToTimestamp))
severity: normalreview: style_camel_caseLine 422: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varFromTimestamp = strtotime($from_date . ' 00:00:00');
severity: normalreview: style_camel_caseLine 425: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varToTimestamp = strtotime($to_date . ' 23:59:00');
severity: normalreview: style_camel_caseLine 434: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
array(':from' => $varFromTimestamp, ':to' => $varToTimestamp))
severity: normalreview: style_camel_caseLine 557: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varFromTimestamp = strtotime($from_year_month_day . ' 00:00:00');
severity: normalreview: style_camel_caseLine 559: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$varToTimestamp = strtotime($to_year_month_day . ' 23:59:00');
severity: normalreview: style_camel_caseLine 568: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
array(':from' => $varFromTimestamp, ':to' => $varToTimestamp))
severity: normalreview: style_camel_caseLine 738: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
function _get_quarter_period($quarterValue = '', $yearValue = '') {
severity: normalreview: style_camel_caseLine 739: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray = array();
severity: normalreview: style_camel_caseLine 740: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
switch ($quarterValue) {
severity: normalreview: style_camel_caseLine 742: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['start'] = strtotime($yearValue . '-01-' . _firstOfMonth(01, $yearValue) . ' 00:00:00');
severity: normalreview: style_camel_caseLine 743: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['end'] = strtotime($yearValue . '-03-' . _lastOfMonth(01, $yearValue) . ' 23:59:00');
severity: normalreview: style_camel_caseLine 746: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['start'] = strtotime($yearValue . '-04-' . _firstOfMonth(01, $yearValue) . ' 00:00:00');
severity: normalreview: style_camel_caseLine 747: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['end'] = strtotime($yearValue . '-06-' . _lastOfMonth(01, $yearValue) . ' 23:59:00');
severity: normalreview: style_camel_caseLine 750: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['start'] = strtotime($yearValue . '-07-' . _firstOfMonth(01, $yearValue) . ' 00:00:00');
severity: normalreview: style_camel_caseLine 751: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['end'] = strtotime($yearValue . '-09-' . _lastOfMonth(01, $yearValue) . ' 23:59:00');
severity: normalreview: style_camel_caseLine 754: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['start'] = strtotime($yearValue . '-10-' . _firstOfMonth(01, $yearValue) . ' 00:00:00');
severity: normalreview: style_camel_caseLine 755: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
$quarterArray['end'] = strtotime($yearValue . '-12-' . _lastOfMonth(01, $yearValue) . ' 23:59:00');
severity: normalreview: style_camel_caseLine 758: do not use mixed case (camelCase), use lower case and _ [style_camel_case]
return $quarterArray;
2. Proper documentation is missing.
3. Strict warnings. See the attched images. Same warning coming for all tabs.
Comment #5
Rkumar commentedBased on #4
https://drupal.org/comment/8517017#comment-8517017
Comment #6
tr commented@Rkumar: Please do not post all that stuff in project reviews. It is sufficient to post a link to the pareview output, e.g. http://pareview.sh/pareview/httpgitdrupalorgsandboxbabruix2179981git
Comment #7
babruix commentedThanks for review!
Changed module code to follow Drupal standards.
At least coder-review says "No Problems Found".
Added proper documentation.
Comment #8
tr commented@babruix: It doesn't look like you addressed any of the pareview issues from #6. See http://pareview.sh/pareview/httpgitdrupalorgsandboxbabruix2179981git
Comment #9
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.