[D7] MobEye Widget

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please fill out the issue summary according to https://drupal.org/node/1011698

jquery-1.10.2.min.js appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Hi MobEye,

PAReview is reporting issue on the code. Please see
http://pareview.sh/pareview/httpgitdrupalorgsandboxmobeye2204615git

Problem from #2 still stands.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

The automated review of your project by PAReview has found some issues with your code. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them.

You need to get rid of .gitignore from the repo, and remove the byte order mark at the beginning of README.txt (which is otherwise 7-bit US-ASCII).

The rest are just formatting errors, but they should be simple to fix.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code/content

Yes: Follows the guidelines for 3rd party code.

Project page

No.

The current projevt page is just meningless marketing blurb that should have been a paid advertisement.
Please take a moment to make your project page follow tips for a great project page.

README.txt

No,

It just repeats the meningless marketing blurb on the project page.
What's lacking are, requirements, how to install, how to configure, and how to use it.
After installing it and the required wysiwyg module, nothing happened. Not a trace of the MobEye widget anywhere.
I understand (from reading the code, not the README.txt), that it is a widget for wysywyg, but I've no idea what a widget for wysywyg is or how to use one. The user should not have to analyze the code to locate the user interface of a module.
Please take a moment to make your README.txt follow the guidelines for in-project documentation and the README.txt Template.

Code long/complex enough for review

No.

The project is only 20 lines of PHP code (after stripping comments and blanks). It is short enough to be reproduced here in full:

function mobeyewidget_wysiwyg_plugin($editor, $version) {
  switch ($editor) {
    case 'tinymce':
      if ($version > 3) {
        return array(
          'mobeyewidget' => array(
            'url' => 'http://mobeye.com',
            'path' => drupal_get_path('module', 'mobeyewidget') . '/tinymce-plugin',
            'filename' => 'mobeye.widget.js',
            'buttons' => array(
              'mobeyewidget' => t('MobEye Widget'),
            ),
            'load' => TRUE,
            'internal' => FALSE,
          ),
        );
      }
      break;
  }
}

It is too simple to count as a real module, as it is a single hook with no configuration settings and no user input.
It does not follow the guidelines for project length and complexity.
And in its current state, I am not even able to make it do anything (useful or unuseful).
A larger and more complex project should have been submitted for review to apply for the "Create Full Projects" permission. (But I shall leave it to a git admin to make a final call on this.)

Secure code

The PHP follows guidelines for writing secure code. In 20 lines of PHP there is not much that can go wrong. But since am no good with JavaScript, somebody else need to review that part of the project.

Coding style & Drupal API usage

It is too small to make a review meaningful. I shows that the applicant knows what a hook is and that using facing text should be wrapped in t() - but beyond that there is too little to review to determine whether the applicant have the required knowledge about Drupal and the Drupal API.

Setting status.

tiny_mce_popup.js appears to be 3rd-Party code. Is it GPL V2 Licensed?

Short projects are perfectly fine, we just can't give the git vetted user role away. However, we can promote this single project manually to a full project for you.

tiny_mce_popup.js appears to be 3rd-Party code. Is it GPL V2 Licensed?

@gwprod - thanks for spotting this.

Yes this is 3rd party code and it is made available under LGPL V2.1. I think LGPL V2.1 is considered compatible with GPL V2+.

However, the current guidelines requires explicit permission from the webmasters to include any 3rd party asset, so I am pulling out the standard template for this issue:

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.