[D7] Commerce DPS Account To Account

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgarethhallnz2199835git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi

The main point: It would be nice to have some test merchant credentials attached to the issue.

What about the code:

1) No more than 1 whitespace required after the key when declaring an array. I agree that it looks fancy but it is not a drupal coding style practice.

$items['commerce_dps_account_to_account_pxpay/fprn'] = array(
    'page callback'   => 'commerce_dps_account_to_account_process_fprn',
    'page arguments'  => array(),
    'access callback' => TRUE,
    'type'            => MENU_CALLBACK,
  );

2) When you are declaring an XML string you should probably avoid hardcoding the tags in the php or at least duplicating htmlspecialchars() for each tag.

3) commerce_dps_account_to_account.module line 24

'page arguments' => array(),

are you sure you need to declare an empty array if the callback does not receive any arguments?

Gareth, if you'd rather keep the DPS functionality together, I'm open to this module being included in Commerce DPS. If so then feel free to add it via #2100685: Account 2 Account integration.

Does A2A really use the PxPay XML? commerce_dps_pxpay.inc and commerce_dps_account_to_account.inc are mostly identical (I haven't checked if you're using those functions in the main module).

Looks like A2A may be missing some DPS improvements (eg special handling for currencies without cents, eg JPY) and I see commerce_dps_*_currencies() has been modified - do you think there's benefit to sharing those improvements by having them in a commerce_dps.inc instead of in two modules?

I agree that this should go into the existing module. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. So let's get this into the existing module, looks like the maintainer is eager to support you.

If that fails for whatever reason please get back to us and set this back to "needs review".

Ok, but I think you should document the related module on your project page?

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. commerce_dps_account_to_account_process_fprn(): instead of invoking drupal_not_found() you can simply return the constant MENU_NOT_FOUND.
2. "drupal_alter('commerce_dps_account_to_account_merchant_reference', $reference, $order, $settings);": Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

Gareth, I don't concur with your estimate of integration taking six months - I've already said that I'm happy to commit the code here to Commerce DPS. Adding this to the existing module has no conflicts AFAICT, except README.txt which I *think* is manageable ;)

This could be committed today (or last week, or whenever) and any code merging can be done down the track. That seems simplest, but it's your contribution and you're welcome to do with it what you prefer - the community benefits either way.

sorry, saw this too late

As I haven't touched PHP or Drupal in the last couple months I don't think it's a good idea to let me decide on anything like this ;)

I'll make an exception here because your code looks well written and well documented and .. because if klausi says it's ready he's usually right.

One thing catched my eye though:

here you do that
drupal_alter('commerce_dps_account_to_account_merchant_reference', $reference, $order, $settings);

and in commerce_dps_account_to_account.api.php you describe it like that:
function hook_commerce_dps_account_to_account_merchant_reference($reference, $order, $settings) {

but I am pretty sure that it's actually like that:
function hook_commerce_dps_account_to_account_merchant_reference_alter($reference, $order, $settings) {

Maybe take another look at the drupal_alter() api documentation:
https://api.drupal.org/api/drupal/includes%21module.inc/function/drupal_...

you should really test whether your hooks work the way you intended them to work before releasing this! ;)

beside that everything looks pretty solid, therefore

Thanks for your contribution, garethhallnz!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.