[D7] Save Redirect On Delete

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi gaurav.goyal,

Manual review:

1. save_redirect_on_delete.admin.inc line 9: this is not an implementation of hook_form
2. save_redirect_on_delete.admin.inc line 11: the parameters are superfluous. You are creating a new admin form so they can be deleted.
3. save_redirect_on_delete.install line 45: I'm guessing you are not really deleting all pathauto variables. Perhaps a typo in the comment line?

Hi gaurav.goyal,

Results of manual review:
1) 46:save_redirect_on_delete.admin.inc - maybe need to use !itemlabel instead @itemlabel, because I see markup as plain text for taxonomy.
<em class="placeholder">Tags</em>

In general looks great. Thank you!

Hi Gaurav,

Did a manual review. its a great module.
Noticed just two problems
1. the one which sanchez has conveyed in the last comment.
2. In the function save_redirect_on_delete_save_entity_redirect($type, $entity) on line 120 in save_redirect_on_delete.module, the call to save_redirect_on_delete_path_pattern($entity, $type) must be after you check that alias is not empty. It makes extraneous calls to database.

Cheers!!

Just found this thread after having done a review on this thread - why are there 2?

Assuming this is the same project I've given some feedback here about an endless redirection loop after saving a node with a alias that already exists.

@dahousecat: This issue is in the project applications queue (which is the right place for a project application), the other appears to be in the project's sandbox issue queue (which is a fine place for getting feedback but won't get you approved as a project).

I'm thinking this is probably the "correct" one and the other should be considered the "duplicate".

Need a check to prevent endless redirect loop when saving a node with an alias that already exists.

Hi gaurav.goyal,

I can confirm the issue with the endless redirect is fixed :)

I did however find these 3 issues:

• Could not get it to redirect to my custom URL after visiting a deleted users url alias.
• After deleting a taxonomy term I got the error message: Notice: Undefined variable: variable in save_redirect_on_delete_path_pattern() (line 78 of /var/www/test/htdocs/sites/all/modules/save_redirect_on_delete/save_redirect_on_delete.module).
• When I visited the deleted taxonomy terms url alias I did not get redirected.

Hi gaurav.goyal,

I can confirm I'm now getting redirected successfully after deleting users, taxonomy terms and nodes. Also the undefined variable bug is fixed.

From a useability point of view I think the module is there :)

There are a few errors on the pareview report but they all look like quick wins.

Fix them and I'll be happy to give you RTBC status.

All looks good to me.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/save_redirect_on_delete.install
  --------------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------------
   5 | ERROR | Doc comment short description must start with a capital letter
  --------------------------------------------------------------------------------
  
  FILE: /home/klausi/pareview_temp/save_redirect_on_delete.module
  --------------------------------------------------------------------------------
  FOUND 7 ERRORS AFFECTING 6 LINES
  --------------------------------------------------------------------------------
     4 | ERROR | Doc comment short description must start with a capital letter
    59 | ERROR | Type hint "array" missing for $path
    97 | ERROR | Type hint "array" missing for $path
   121 | ERROR | Type hint "unknown" missing for $path
   137 | ERROR | Type hint "unknown" missing for $source
   137 | ERROR | Type hint "unknown" missing for $dest
   182 | ERROR | Type hint "unknown" missing for $alias
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. save_redirect_on_delete_install(): No need to set variables upon installation as you can make use of default values with variable_get() anyway.
2. save_redirect_on_delete_install(): do not juggle with module weights as that is unreliable. Use hook_module_implements_alter() instead if you need to run before/after a specific hook of another module.
3. save_redirect_on_delete_install(): all variables defined by your module should be prefixed with your module's name to avoid name clashes.
4. save_redirect_on_delete_path_pattern(): $variable will be undefined if neither case in the switch() is executed. I guess then you must not create any redirect?
5. "unknown" is not a valid data type in the doc blocks, see https://drupal.org/node/1354#types

But that are not critical application blockers, so ...

Thanks for your contribution, gaurav.goyal!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.