Flickr/Flickr sets - seems like flickr has had a backend change and that makes Flickr_sets unworkable - previously slideshows were brought in, but now the attached error message appears.

CommentFileSizeAuthor
#8 flickr-object_instead_of_iframe-2212201-8-D6.patch4.04 KBvinmassaro
#4 object_instead_of_iframe-2212201-4.patch3.61 KBlolandese
#3 object_instead_of_iframe-2212201-3.patch3.59 KBlolandese
#2 object_instead_of_iframe-2212201-2.patch3.21 KBlolandese
#1 object_instead_of_iframe-2212201-1.patch1.59 KBlolandese
flickr-error.jpg24.85 KBAndy_Alert

Comments

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new object_instead_of_iframe-2212201-1.patch1.59 KB

It indeed appears that iframe slideshows are now broken. See https://www.flickr.com/help/forum/en-us/72157641877625913/.

Attached patch uses <object> instead of <iframe> which solves the issue.

As the object type slideshow needs also a photo owner user-id besides the set-id, we added some code to grab that.

Thanks for reporting.

lolandese’s picture

lolandese commented
StatusFileSize
new object_instead_of_iframe-2212201-2.patch3.21 KB

Improved version with both a Flash and non-Flash slideshow display to choose from (at admin/structure/types/manage/[node-type]/display).

Furthermore we use a width of 100%. The height is fixed at 500px, therefore a bit but not really responsive.

lolandese’s picture

lolandese commented
StatusFileSize
new object_instead_of_iframe-2212201-3.patch3.59 KB

Even better, truly responsive. Thanks to http://yetti.co.uk/blog/articles/responsive-iframe-objects-and-embeds.html.

lolandese’s picture

lolandese commented
Issue tags: -flickr iframes
StatusFileSize
new object_instead_of_iframe-2212201-4.patch3.61 KB

Still the Flash slideshow would render on top of everything else, especially annoying in combination with Lightbox/Colorbox.

Solved thanks to:
Flash and the z-index problem, solved ← slightlymore (the online residence of Clinton the intertube sorcerer)

shandman’s picture

shandman commented
Status: Needs review » Reviewed & tested by the community

Seems to work.

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/flickr.git/commitdiff/d71383e

Thanks for the feedback.

lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
vinmassaro’s picture

vinmassaro commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new flickr-object_instead_of_iframe-2212201-8-D6.patch4.04 KB

@lolandese: I've ported this patch to D6 and tested it. Can you review and commit? Thanks!

lolandese’s picture

lolandese commented
Component: flickr_sets » flickr_field
Status: Needs review » Fixed

Patch applied cleanly. Tested both Flash and non-Flash slideshow on 'Flickr Photo set' field. All fine.

Committed with attribution: http://drupalcode.org/project/flickr.git/commitdiff/3cf8e06

Thanks a lot.

If there are other new functionalities of your interest for D6, feel free to port.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.