Closed (fixed)
Project:
Breakpoint Panels
Version:
7.x-2.0
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Feb 2014 at 17:17 UTC
Updated:
3 Apr 2014 at 18:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehner.
Comment #2
dawehner.
Comment #3
hydra commentedThis fixed a half ton of issues for me and needs defenetly be commited in order to use this module. Thx for this!
Comment #4
hydra commentedThe 2. patch only works after applying https://drupal.org/node/2186159
Comment #5
svajlenka commentedThe patch in #2 is fantastic and should absolutely get committed!
Comment #6
svajlenka commentedAh, I ran into some issues with the above patch.
* IPE integration was not updated to use the task/subtask id for the task handler
* In cases where there was no subtask (in my case this was node_view) the patch failed to save breakpoint configuration for the pane
I've attached a patch (to apply after #2) for review, I've also ran the module through code review (using --minor) to clean up the module in general.
Comment #7
svajlenka commentedreroll of my above patch with an additional fix for the no subtask id situation...
Comment #8
svajlenka commentedI just keep finding small issues. Attached is a reroll with an additional fix (for the display) of panes with no subtask.
Comment #9
svajlenka commentedCommitted patches 2 and 8. Thanks!