Closed (fixed)
Project:
Breakpoint Panels
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Jan 2014 at 13:57 UTC
Updated:
20 Mar 2014 at 17:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hydra commentedComment #2
hydra commentedComment #3
steffenrHi @Hydra - i just had a look at your patch - looks fine for me and well documented.
SteffenR
Comment #4
hydra commentedFixed the settings arry, to not override the default stlye settings key.
Comment #5
dawehnerThis worked fine for me as well, and it looks like a reasonable approach, even we want to have something more ctools/panels-native on the longrun probably.
Comment #6
dawehnerThese are the lines which page_manager use for its hook_menu() entries, 'theme callback' allows you to inherit the used theme of the "parent" page theme
independent from the path.
Comment #7
hydra commentedThis is just awesome, thx dawehner, I had no clue how to fix this one, so I just lived with it.
Comment #8
mvdve commentedTested patch #6 and works like a charm. Please commit.
Comment #9
svajlenka commentedI tested the patch provided in #6 and while it did add breakpoint settings links to all the pane context links. However, because it does not check for the existence of $pane->did, when you click `breakpoint settings` on a pane that is stored in code, an error is generated while displaying the breakpoint settings form.
Comment #10
svajlenka commentedWrapped breakpoint_panels_get_pane_links_alter in check for $pane->did to address the issue encountered in #9
Comment #11
svajlenka commentedComment #12
svajlenka commentedPlease disregard the patch I posted above. I've corrected this issue with this more comprehensive patch: https://drupal.org/comment/8580927#comment-8580927
Comment #13
svajlenka commentedYay I'm a co-maintainer now! I've committed the patch in #6.