New URL to respond.min.js (GitHub)

Hi, thanks for the report! This definitely needs updating.

Your patch is great (and even cleans up some tech debt of mine, thanks!), but it doesn't catch all instances of the URL. Perhaps we could take this opportunity to consolidate them all into one location.

I will commit your patch as-is to give you credit, and followed up with my own. Can you test this new patch and if it works well set the status to "Reviewed & tested by the community" (RTBC)? When testing make sure to uninstall and install again.

Also just for the future, when you have a patch you want a maintainer to review, use the "Needs review" issue status. That will help people review it quicker!

trying to figure out the error / path to the respond.js file as well..
I've applied these patches.. uploaded various configurations for the respond.js respond.min.js file but not having success w the script being recognized..

I'll keep trying - but having same issue.. thx.

zachleat responded to this issue:
https://github.com/scottjehl/Respond/issues/252, creating 'New dest files' at [see] History for Respond / dest.

I updated Respond.js Install Doc at https://drupal.org/node/2032637 to reflect the changes (new 'dest' directory) that Zachleat made (see also, Comment #20) and I Closed #2014807: Respond.js module should provide proper installation location for upstream library.

I'm still very new. Love Drush. Have not figured out GitHub, Git, Gui, et al yet. I'm just getting started with Views, eventually Themes and other good stuff. Looking to do great design stuff. I'm from the "promote" old-school manual log process days. I'm an analyst not a programmer, but I will probably dabble.

So,-- Am I doing this right?

If so, can we Close this Record too?

No this is a patch to fix the module which is currently broken. We need to keep this open until we get a patch RTBC and committed to dev.

trying to figure this out still. confounded.
updated the module to respondjs-7.x-1.x-dev ..
deleted & replaced the respond library using drush ( very convienent..thank you)
status shows the respondjs is active ... green, aggregation - compression enabled
clearing caches..

running patch 3 jan 22 by rupl and I get this error message..

can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/drush/respondjs.drush.inc b/drush/respondjs.drush.inc
|index 3026256..9dde7a2 100644
|--- a/drush/respondjs.drush.inc
|+++ b/drush/respondjs.drush.inc
--------------------------
File to patch: 2179017-download-url-3.patch
patching file 2179017-download-url-3.patch
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file 2179017-download-url-3.patch.rej
patching file respondjs.install
Hunk #1 FAILED at 30.
1 out of 1 hunk FAILED -- saving rejects to file respondjs.install.rej
patching file respondjs.module

posted the file name and got this in respondjs.install.rej

***************
*** 30,43 ****
if (function_exists('libraries_get_path') && strpos($library_path,'libraries/respondjs') === FALSE) {
$requirements['respondjs']['value'] = t('Respond.js is not correctly using Libraries API');
$requirements['respondjs']['severity'] = REQUIREMENT_WARNING;
- $requirements['respondjs']['description'] = t('Please install Respond.js in '. libraries_get_path('respondjs') .'. The module is using its included copy at '.drupal_get_path('module','respondjs') .'/lib');
}
// If the included copy of respond.js has been removed or renamed report an error.
// At this point the module cannot function properly.
if (!file_exists($library_path)) {
$requirements['respondjs']['value'] = t('Respond.js is not correctly installed');
$requirements['respondjs']['severity'] = REQUIREMENT_ERROR;
- $requirements['respondjs']['description'] = t('Please install Respond.js in the repsondjs folder under /lib');
}
}
return $requirements;
--- 30,43 ----
if (function_exists('libraries_get_path') && strpos($library_path,'libraries/respondjs') === FALSE) {
$requirements['respondjs']['value'] = t('Respond.js is not correctly using Libraries API');
$requirements['respondjs']['severity'] = REQUIREMENT_WARNING;
+ $requirements['respondjs']['description'] = t('Please install Respond.js in '. libraries_get_path('respondjs') .'. The module is using its included copy at '.drupal_get_path('module','respondjs') .'/lib', array('@url' => RESPONDJS_DOWNLOAD_URI));
}
// If the included copy of respond.js has been removed or renamed report an error.
// At this point the module cannot function properly.
if (!file_exists($library_path)) {
$requirements['respondjs']['value'] = t('Respond.js is not correctly installed');
$requirements['respondjs']['severity'] = REQUIREMENT_ERROR;
+ $requirements['respondjs']['description'] = t('Please install Respond.js in the repsondjs folder under /lib', array('@url' => RESPONDJS_DOWNLOAD_URI));
}
}
return $requirements;

still working on making this work.
reviewed permissions.. tested
just cannot get this to work on my navigation menu..

apologize if I'm seeming dense on this here. ..

thanks

Thanks for reviewing the patch. Looks like it needs to be re-rolled manually. We've have a couple commits since January 22.

Here is a re-roll / reimplementation of the patch for the current 7.x-1.x branch.

This patch applied against latest dev, but it seems to fix issues I had already resolved in this commit: 099e252.

Can you make sure you have latest dev or download 7.x-1.4 (I tagged the commit with 1.4 on account of it breaking multiple distros that were depending on the fix). There might still be a problem, but I want to make sure we're all looking at the same version.

Nevermind, I get it now. This patch is indeed needed in some form. Thanks for your re-roll, it brought my attention to the mistake I made in the previous commit. Darn, needs a new release now.

Ok here's an update that uses vars for both download URI and final location in libraries dir. It also corrects a couple spelling mistakes.

I see. Makes perfectly sense to me in this way. Thanks!

Thanks for the review!