Overview

Youtube feed block is a simple module that creates a block of youtube video thumbnails displayed as links to their respective videos. It is specifically designed to give a good control over the videos' thumbnails, and allows the user to crop and rescale them.

This module is different from others because it does not try to import any data in the website's database (although it might try to cache it's content in later versions), nor does it try to generate an Iframe within it's block. It's main aim is to give a clean and simple way to display someone's latest videos as a list of links without adding more time to the page's rendering time.

Project page: Youtube feed block

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Marc-Antoine/2199719.git youtube_feed_block

Comments

Marc-Antoine’s picture

Issue summary: View changes
Marc-Antoine’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxMarc-Antoine2199719git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Marc-Antoine’s picture

Issue summary: View changes
Marc-Antoine’s picture

Issue summary: View changes
Marc-Antoine’s picture

Status: Needs work » Needs review
jkswoods’s picture

Status: Needs review » Needs work

I noticed in your youtube_feed_block_link.tpl.php file on line 14 you have:

<div>
  <?php echo $value['video_link']; ?>
</div>

Is there a need for this div element doesn't really seem to be doing anything?

Other than that looks like a very nice module.

Marc-Antoine’s picture

Status: Needs work » Needs review

Thank you for your comment, indeed this div was unnecessary and I also simplified the foreach. I tested and everything still works as intended.

stred’s picture

Status: Needs review » Needs work

Hi Marc-Antoine,
here is my review

1 Basic application checks.
similar features provided by https://drupal.org/project/youtubechannel https://drupal.org/project/feeds_youtube
beyond the internal code architecture you mentioned in the description, the advantage to use this module is not clear on a user perspective...
2 repository checks.
ok
3 Security .
for me you should always validate input even if it comes from YouTube
4 Licensing .
ok
5 Documentation.
you should add the configure link in the .info file
configure = "config/media/youtube_feed_block"

implement display of errors if something is wrong: if ($youtube_answer->code != 200)

6 Coding standards.
pareview http://pareview.sh/pareview/httpgitdrupalorgsandboxmarc-antoine2199719git-0 doesn't output nothing
comment on line 168 doesn't start with capital letter.
7 API
use built in drupal functions in .module file
on line 256 you should use truncate_utf8()
230: drupal_json_decode()
in the js file you should use the Drupal.behaviors wrapper https://drupal.org/node/171213

except that this is a really great module, very easy to use!

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.