Problem/Motivation

The social sharing dialog currently can only be closed by clicking the button once again. People might expect they can close the dialog by clicking anywhere else on the page.

CommentFileSizeAuthor
#3 3427109-offcanvas_close_on_click-2.0.x-3.patch5.38 KBmrshowerman

Issue fork openculturas-3427109

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrshowerman created an issue. See original summary.

mrshowerman opened merge request !5

mrshowerman’s picture

mrshowerman
Location Munich
commented
Assigned: mrshowerman » Unassigned
Status: Active » Needs review
StatusFileSize
new 3427109-offcanvas_close_on_click-2.0.x-3.patch5.38 KB

Opened MR against 2.1.x, adding patch against 2.0.x.

hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented

Sounds good, makes absolute sense.

tobiasb closed merge request !5

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Fixed

"Merged" into 2.1.x. ;-)

  • tobiasb committed bc3c3836 on 2.1.x 
    Issue #3427109: Close sharing dialog on click

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.