Needs review
Project:
OpenCulturas
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jul 2024 at 13:42 UTC
Updated:
31 Mar 2026 at 15:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mrshowermanSee attached patch.
Comment #3
hexabinaerLooking into it, the approach makes sense for the
related_dateview.However, I doubt it will work for
oc_map_datesbecause as far as I remember this filter would not be reflected in the module's code. Have you really successfully tested that filter in an "OC Map"?Comment #4
hexabinaerUpon second thought, I might make sense to change the publishing workflow for dates then (default published). As a second step.
Comment #5
mrshowermanAs far as I know, yes. Otherwise the map on https://beta.kultino.de/node/9 would show dozens of "Jever Brauereiführung" dates.
Comment #6
moritz.steinhauerWe should keep one thing in mind: dates and events might belong to different users. If an ensemble unpublishes an event, all dates (that might be published by locations that host an event) will no longer be visible. But this seems like an edge case to me.
What might be more problematic: often users with the role oc-organiser forget to publish events and only publish their dates. At the moment, this is not a big problem because the text of the event is still rendered in the date, even if the event is unpublished. If we apply mrshowermans patch, we should also change the publishing-workflow for events. Otherwise there will be much more supports-requests caused by "missing dates" in the calendar :-D
Comment #7
hexabinaerGood point @moritz.steinhauer. This might be very dependent from how calendar content is created and how site owners set the rules.
It makes sense when events + corresponding dates are imported and published by default. However, we can have different scenarios.
Maybe a more generic solution would rather be found with an optional ECA function and let site-owners decide to unpublish or even delete dates related to the event in question?
Comment #8
hexabinaerOops, so sorry. #3 was related to a different issue :-}
Comment #9
tobiasb