Closed (fixed)
Project:
OpenCulturas
Version:
2.3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Jul 2024 at 16:23 UTC
Updated:
25 Sep 2024 at 14:44 UTC
Jump to comment: Most recent
Problem/Motivation
Directions links on locations and date pages currently work only on Android, due to the fact that they are using URLs with the geo: protocol.
Sites built on top of OpenCulturas may decide to use a different approach, such as OpenStreetMap or Google Maps URLs.
Similarly, it would be nice to be able to show links to public transport providers in the site's region, also based on the address field of a location.
This issue is for providing a general framework to achieve these goals.
Proposed resolution
Create a custom module OpenCulturas Address Links which offers a configuration form for defining the site's selected directions and public transport provider URLs. These URLs may contain tokens for real-time replacement of address info (e.g., latitude/longitude or the plain address). Integrate directions and public transport links both for template and field formatter based layouts.
Remaining tasks
- Write update script that activates the new module
- Review styling of links in base theme
Issue fork openculturas-3462443
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3462443-configurable-directions-and
changes, plain diff MR !7
Comments
Comment #3
mrshowermanOK, I think this is ready for review.
The new module has a settings form at /admin/config/services/openculturas_address_links where you can specify URLs of your chosen directions and public transport provider. You can use tokens to include location coordinates or its plaintext address.
By default, the public transport URL is empty, and the directions URL is set to
geo:[geofield:latlon]to make it BC with the current behaviour.Example settings from KultinO:
https://www.google.de/maps/dir/?api=1&destination=[geofield:latlon](directions)For OpenStreetMap, this could also be
https://routing.openstreetmap.de/?z=18&loc=[geofield:latlon]&hl=[language:langcode]&srv=0.https://www.vbn.de/fahrplaner/?start=yes&language=[language:langcode]&L=vs_vbn&Z=[address:address](public transport)I've updated the
openculturas_base_preprocess_paragraph()hook in the base template, so it now calls the new service for including links. This wil only work if the new module is activated, thus we will need an update script that enables it.For sites that prefer using field formatters together with field copies (like KultinO), the module also contains two new formatters.
Comment #4
hexabinaerAwesome, I'll look into it.
On first reading of your description I wondered if this could work as a generic module (without OC dependency).
Comment #5
mrshowermanI've asked myself the same thing. Theoretically, it could also be seen as an independent module, but as we only use it in an OC context (so far), I have treated it in the same way as the other modules for the time being.
Comment #6
tobiasbComment #9
tobiasbMerged module. Some changes for CS/phpstan/rector happyness.
The config values in
openculturas_address_links.settingsare now nullable. Because a empty string is not a valid uri.The modul will be installed via update-hook.
Comment #10
mrshowermanAwesome.
I'd really like to get credit for this one 😉
Comment #11
tobiasbComment #12
hexabinaer@mrshowerman On trying to construct a link with tokens there's a glitch:
Always results in a modal message "First click a text field to insert your tokens into.".