FullCalendar doubling on page [#1039912]

Comment	File	Size	Author
#6	fullcalendar-1039912-D6.patch	749 bytes	tim.plunkett
#4	fullcalendar-1039912-4.patch	732 bytes	tim.plunkett
	screenshot_30.jpg	236.29 KB	tchopshop

Comment #1

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 25 January 2011 at 19:37

When Colorbox closes, it re-runs the fullcalendar script.
We need to add a .fullcalendar-processed, and check for it.

Log in or register to post comments

Comment #2

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 19:45

Do you think the multiple instances of Full Calendar on a page are what would be causing a "slow script" error in my browser? Because that has happened to me several times, forcing me to have to force quit my browser, since it completely stalls trying to run the javascript.

Log in or register to post comments

Comment #3

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 25 January 2011 at 20:20

Title:	Full Calendar doubling on page	» FullCalendar doubling on page
Version:	6.x-1.3	» 7.x-1.x-dev

Very likely, especially if you have a lot of nodes.

This will be backported rather quickly, but the development is happening in D7 at the moment.

Log in or register to post comments

Comment #4

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 25 January 2011 at 20:27

Status:

Active

» Needs review

File	Size
fullcalendar-1039912-4.patch	732 bytes

Wow D7 is awesome, it includes the once() library.

This is going to be a pain to backport.

Log in or register to post comments

Comment #5

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 20:42

Thank you for all your work...

How long do you think I need to wait for this backport? (I'm not a programmer, or I would help you!!!)

I really don't want to have to go back to the regular calendar module... but my client's site goes live at the end of this month.

Log in or register to post comments

Comment #6

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 25 January 2011 at 21:08

File	Size
fullcalendar-1039912-D6.patch	749 bytes

Less than an hour is pretty good...

Log in or register to post comments

Comment #7

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 21:13

Wow! you are an amazing man!

Log in or register to post comments

Comment #8

aspilicious CreditAttribution: aspilicious commented 25 January 2011 at 21:20

Status:

Needs review

» Reviewed & tested by the community

Both are rdy to go!

Log in or register to post comments

Comment #9

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 21:46

Status:

Reviewed & tested by the community

» Needs review

You are so quick!

But maybe I am doing something wrong...

I applied the patch, but it is still doubling the calendar on the page. Is there some secret configuration I'm missing now?

And maybe I'm mistaken, is this patch attempting to solve the doubling problem, or another issue with colorbox (like showing the full page instead of just the content)? I had solved that problem by creating a blank page template for colorbox that only showed content, with no page surround.

Log in or register to post comments

Comment #10

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 25 January 2011 at 21:49

tschopshop:
The full page part is being handled in #910494: Colorbox version and settings.

Once you apply the patch, and clear the cache, this should work.
Can you try it again and make sure?

admin/settings/performance to clear the cache.

Log in or register to post comments

Comment #11

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 21:57

Yes, I definitely cleared the cache... several times...

Do you want me to give you any more info? I wonder if it's some other conflict.

:(

Log in or register to post comments

Comment #12

geerlingguy CreditAttribution: geerlingguy commented 25 January 2011 at 22:26

Status:

Needs review

» Reviewed & tested by the community

Fixed the problem for me - applied the patch to the latest FC stable release (D6 branch), cleared all caches, and the problem went away completely.

Log in or register to post comments

Comment #13

tchopshop CreditAttribution: tchopshop commented 25 January 2011 at 23:35

Maybe I should start again with a new installation. But I'm just double checking in case I missed something... do I just apply the patch from #6 by itself, or do I apply this patch in addition to another one (like the one from #4)?

Log in or register to post comments

Comment #14

aspilicious CreditAttribution: aspilicious commented 25 January 2011 at 23:39

only 6 is needed. Do you have an online link to the calendar?

Log in or register to post comments

Comment #15

tchopshop CreditAttribution: tchopshop commented 26 January 2011 at 05:06

Hi there, I'm testing it locally. But maybe I will move it to the test server, if it comes down to that. But here's some more information -- the version I'm applying it against is from some time in the fall -- November, I think.

And when I update the code to the most recent version to get the file to which the patch applies, all our events disappear as soon as the fullcalendar script executes.

In November when we implemented Full Calendar we patched the module to support repeating events, color-coding, and our simplified template for Colorbox (because we couldn't use the module with it bringing in a full page inside the Colorbox). All those patches no longer work with a new version of the code.

Not sure what to do next, but maybe I should set up a new trial site with new code, to see if we can get the functionality we need, before attempting to bring it into our system.

thank you for your help, I hate to be such a burden....