Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This module has been absolutely indispensable for keeping my site spam-free. A port to Drupal 7 would be incredibly helpful.
Comment | File | Size | Author |
---|---|---|---|
#49 | spam_7.x-1.x-dev.zip | 91.47 KB | Frank Ralf |
Comments
Comment #1
JimmyAx CreditAttribution: JimmyAx commented+1
Comment #2
Serjo CreditAttribution: Serjo commented+1
Comment #3
TimG1 CreditAttribution: TimG1 commented+1 subscribing
Comment #4
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedSubscribe.
Comment #5
Orange CreditAttribution: Orange commentedYes, I'm running version 7 and the spam is incredible.
Comment #6
7wonders CreditAttribution: 7wonders commentedsub
Comment #7
rogical CreditAttribution: rogical commented+1
Comment #8
W32 CreditAttribution: W32 commented+1
Comment #9
mohammed76changing issue title to include project name.
Comment #10
zkrebs CreditAttribution: zkrebs commentedsubscribe, please :)
Comment #11
dwalker51 CreditAttribution: dwalker51 commented+1
Comment #12
benhelps CreditAttribution: benhelps commented+1
Comment #13
Dave Cohen CreditAttribution: Dave Cohen commented+1
Comment #14
Cray Flatline CreditAttribution: Cray Flatline commentedsubscribing
Comment #15
monican CreditAttribution: monican commented+1
Comment #16
RogueM CreditAttribution: RogueM commentedsubscribing
Comment #17
espirates CreditAttribution: espirates commentedsubscribe+
Comment #18
alpp CreditAttribution: alpp commented+1
Comment #19
laura s CreditAttribution: laura s commentedSubscribe.
Comment #20
anarcat CreditAttribution: anarcat commentedI am so sorry for this: +1. :)
Comment #21
invantix CreditAttribution: invantix commented+1 please port!
Comment #22
dwalker51 CreditAttribution: dwalker51 commentedThere is a little green button above to follow the issue, it is not necessary anymore to comment. :)
Comment #23
espirates CreditAttribution: espirates commentedThey should put a follow button at the bottom too, after scrolling through many comments you'll have to scroll back up to the top to click the button.
Comment #24
laura s CreditAttribution: laura s commented@espirates #23 is in the wrong issue.
Comment #25
danielm CreditAttribution: danielm commentedSubscribe
Comment #26
marko3 CreditAttribution: marko3 commentedIndeed the main reason that I have not migrated to D7 yet is lack of spam module there. Porting will be greatly appreciated for people like me how are heavily reliant on this indispensable gem.
Comment #27
rogical CreditAttribution: rogical commentedas this module is in active maintenance, there should be a word that the maintainer would like to port to D7, or just add new maintainer who would do the port.
Comment #28
AlexisWilke CreditAttribution: AlexisWilke commentedI'm afraid that the 4 "active" maintainers don't have much time to do anything major at this time...
If someone has the skills, then he's more than welcome to step in (although one of the maintainers was kind of against it because the D6 is not really 100% there yet... but I personally don't see much of a problem with it. Actually, it may help fix a few problems in the D6 version!)
Thank you.
Alexis Wilke
Comment #29
Franz-m CreditAttribution: Franz-m commentedwebchick just published "Hit-list for top Drupal 7 module stabilization" (http://webchick.net/node/103, via http://drupal.org/planet )
There a lot of other modules make "her priority list", but she also describes how to get in without being a maintainer, and this recommendations maybe fit for the spam module too.
But:
I occasionally look over the spam module issues with similar intention, but did not manage a result yet, not sure whether I really can help.
Comment #30
stg11 CreditAttribution: stg11 commentedsub
Comment #31
Hanno CreditAttribution: Hanno commentedsub
Comment #32
mototribe CreditAttribution: mototribe commentedplease use the "follow" button on top to subscribe to a post.
Comment #33
mgiffordHas anyone tried running this through the Coder module to simply develop a patch that we can then work from?
Comment #34
uno CreditAttribution: uno commentedOn my wish list for a year now.
Almost 3800 sites are using this great module, please don't let it die.
Comment #35
mgiffordI did try the Coder Upgrade & got this error ( ! ) Fatal error: Call to undefined function spam_invoke_api() in /Users/DRUPAL7/sites/all/modules/contrib/coder/coder_upgrade/conversions/begin.inc(143) : eval()'d code on line 27.
The function is in the .module file, but not sure why this is failing.
Comment #36
AlexisWilke CreditAttribution: AlexisWilke commentedmgifford,
That function is defined in spam/spam.module. However, the module does all sorts of include of .inc files. That is not unlikely a problem when porting with an automated process like this.
Good luck,
Alexis
Comment #37
mgifford@Alexis ya, thanks. I hadn't seen that error in Coder before. Looks like a bug in Coder more than anything else. Although Coder can deal with include files easily enough I think.
Anyways, I was just trying to help nudge this along. This isn't an urgent issue for me at the moment.
Comment #38
klonosThis module has been mentioned quite a lot in #1293186: Spam - meta: better spam-combating suggestions (and in other related issues too) and it's been proposed to be included in d.o: #1378456: Install Spam module on drupal.org. I think that in order for it to have more chances, it would be a plus if it already had a 7.x version. Reason being that it would make it easier for the initiative to port d.o to D7. So, even if its current 6.x branch maintainers don't have the time to also take the burden of a new 7.x branch, I'm confident that having it would attract others that will eventually step up to the task ;)
PS: ...I know I came to this issue a bit late, but when it comes to @espirates concern back in #23, here's the related issue: #1307170: Make "Follow" button more findable
Comment #39
cweagansKilles has said that a spam module port to D7 is not an upgrade blocker for Drupal.org. We can simply turn off the module and reenable it when the port is ready.
That said, I don't think it'll be difficult to port this module. In fact, I started looking at it last night. I wonder if it would be worth making some architectural changes during the port. For instance, I'd like to see the different filters simply become ctools plugins, rather than separate modules.
Anyways, I'm playing with this for a couple hours, so assigning to myself. If you don't hear from me in three days, send in the search parties (or just unassign the issue =P )
Comment #40
cweaganswhoops.
Comment #41
calte CreditAttribution: calte commentedSearch party searching..
Comment #42
cweagansYeah....got sidetracked. Sorry bout that. I'll try to come back around to this when I have time.
Comment #43
ChaseOnTheWebI've started working on a port today. If I make substantial progress within the next week, I'll post a sandbox.
Comment #44
ChaseOnTheWebComment #45
klonosDoes this mean you gave up Chase?
Comment #46
ChaseOnTheWebI'll make a sandbox in the morning and push up what I have.I made some progress, but I do not know how much time I will put toward this in the near future, so I untagged myself.Like #35-#37, I had issues with Coder Upgrade and started doing the port by hand. I'm somewhat of a novice module developer so I've had to come up to speed on Drupal 6 vs Drupal 7 query API. Most of the queries are ported except a few of the functions/hooks that returned customized WHERE clauses and such. I agree with #39 that some functionality would be better done with ctools plugins, but I've been sidetracked the last few days from reading up on those (my job ends tomorrow, so I'll have some time after that :-/).
I'm not so much giving up as trying not to give the appearance of commitment to this.
Update: Here is the sandbox: http://drupal.org/sandbox/marleythedog/1621054 -- code's still pretty rough right now, not yet to runnable stage.
Comment #47
mgifford@marleythedog Seems like it would be worth trying to roll up this as a patch. Glad you made some progress on it.
I'm also assuming you are working off the 6.x-1.x branch of git.
Comment #48
cweagansRemoving unneeded tags and tagging for the d.o spam hitlist
Comment #49
Frank Ralf CreditAttribution: Frank Ralf commentedHere's a quick and dirty update of the code from http://drupal.org/sandbox/marleythedog/1621054
I ran it through Coder and amended some of the critical issues. However, the module still throws a lot of errors when trying to activate it.
Comment #50
CarlHinton CreditAttribution: CarlHinton commentedPlease, please please ... can you add me as a maintainer so that I can get a workable Drupal 7 dev version of Spam up and running ... err did I say please
Comment #51
cweagansNo need for you to be a maintainer to get a workable D7 version. Create a sandbox and commit away. When you get to a workable point, just let somebody know where to look for a review.
Comment #52
mgifford@Frank Ralf can you submit your code as a patch so that it is easier to review?
I've had problems with other contributions as zips where the project is taken a completely different direction. Not that you'd do that, but patches make it easy to review what has changed.
Comment #53
CarlHinton CreditAttribution: CarlHinton commentedI have created a sandbox at http://drupal.org/sandbox/CarlHinton/1749440 - anyone who wants to help will be made welcome
Comment #54
Frank Ralf CreditAttribution: Frank Ralf commented@CarlHinton
Thanks for your efforts. Feel free to use the code from #49 to incorporate it in your sandbox project. IMHO it's better to join forces instead of creating a separate patch (@Mike).
Comment #55
CarlHinton CreditAttribution: CarlHinton commented@Frank
I've fixed the problem with installing the Spam API, it was a simple function spelling error. I'm now working through the sub-modules.
Comment #56
Jeremy CreditAttribution: Jeremy commentedI'm happy to merge it in once it's to a reasonably usable / clean state... please post updates to this issue.
Comment #57
CarlHinton CreditAttribution: CarlHinton commented@Jeremy
It all installs just fine now including the sub-modules. However there are some issues that need to be ironed out, e.g. I'm getting undefined method DatabaseStatementBase::extend() on the filters tab in admin. I'll drop you a line as soon as this is ready for merging.
Comment #58
geresy CreditAttribution: geresy commentedno joy?:(
Comment #59
alpp CreditAttribution: alpp commentedindeed :( does anybody know about any alternatives for d7? honeypot stops some of the spam, but not all...
Comment #60
adammaloneSame as all the other contenders - I'll take a look. If nothing after a week assume I've been categorized as spam.
Comment #61
adammaloneA small update that I've expanded on the work already done in #53 by CarlHinton.
Sandbox is at: http://drupal.org/sandbox/typhonius/1885762
Comment #62
uno CreditAttribution: uno commentedI cannot tell you how glad I am that this little gem is finally moving forward.
Thanks to all for your efforts.
Comment #63
cweagansFor anyone interested, you should take a look at https://drupal.org/project/spam_detect. It's very similar, though a little more lightweight. The default implementation allows you to use Rules for spam detection and filter training, though you can disable the rules integration and just add the filter support programmatically.
Comment #64
apadernoComment #65
chegor CreditAttribution: chegor as a volunteer commentedComment #66
apadernoThis is not an outdated issue, since it's a task for porting the module to Drupal 7.
Comment #67
apaderno