This module has been absolutely indispensable for keeping my site spam-free. A port to Drupal 7 would be incredibly helpful.

CommentFileSizeAuthor
#49 spam_7.x-1.x-dev.zip91.47 KBFrank Ralf
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JimmyAx’s picture

+1

Serjo’s picture

+1

TimG1’s picture

+1 subscribing

Niklas Fiekas’s picture

Subscribe.

Orange’s picture

Yes, I'm running version 7 and the spam is incredible.

7wonders’s picture

sub

rogical’s picture

+1

W32’s picture

+1

mohammed76’s picture

Title: Port to Drupal 7 » Port spam module to Drupal 7

changing issue title to include project name.

zkrebs’s picture

subscribe, please :)

dwalker51’s picture

+1

benhelps’s picture

+1

Dave Cohen’s picture

+1

Cray Flatline’s picture

subscribing

monican’s picture

+1

RogueM’s picture

subscribing

espirates’s picture

subscribe+

alpp’s picture

+1

laura s’s picture

Subscribe.

anarcat’s picture

I am so sorry for this: +1. :)

invantix’s picture

+1 please port!

dwalker51’s picture

There is a little green button above to follow the issue, it is not necessary anymore to comment. :)

espirates’s picture

They should put a follow button at the bottom too, after scrolling through many comments you'll have to scroll back up to the top to click the button.

laura s’s picture

@espirates #23 is in the wrong issue.

danielm’s picture

Subscribe

marko3’s picture

Indeed the main reason that I have not migrated to D7 yet is lack of spam module there. Porting will be greatly appreciated for people like me how are heavily reliant on this indispensable gem.

rogical’s picture

as this module is in active maintenance, there should be a word that the maintainer would like to port to D7, or just add new maintainer who would do the port.

AlexisWilke’s picture

I'm afraid that the 4 "active" maintainers don't have much time to do anything major at this time...

If someone has the skills, then he's more than welcome to step in (although one of the maintainers was kind of against it because the D6 is not really 100% there yet... but I personally don't see much of a problem with it. Actually, it may help fix a few problems in the D6 version!)

Thank you.
Alexis Wilke

Franz-m’s picture

webchick just published "Hit-list for top Drupal 7 module stabilization" (http://webchick.net/node/103, via http://drupal.org/planet )

There a lot of other modules make "her priority list", but she also describes how to get in without being a maintainer, and this recommendations maybe fit for the spam module too.

But:
I occasionally look over the spam module issues with similar intention, but did not manage a result yet, not sure whether I really can help.

stg11’s picture

sub

Hanno’s picture

sub

mototribe’s picture

please use the "follow" button on top to subscribe to a post.

mgifford’s picture

Has anyone tried running this through the Coder module to simply develop a patch that we can then work from?

uno’s picture

On my wish list for a year now.

Almost 3800 sites are using this great module, please don't let it die.

mgifford’s picture

I did try the Coder Upgrade & got this error ( ! ) Fatal error: Call to undefined function spam_invoke_api() in /Users/DRUPAL7/sites/all/modules/contrib/coder/coder_upgrade/conversions/begin.inc(143) : eval()'d code on line 27.

The function is in the .module file, but not sure why this is failing.

AlexisWilke’s picture

mgifford,

That function is defined in spam/spam.module. However, the module does all sorts of include of .inc files. That is not unlikely a problem when porting with an automated process like this.

Good luck,
Alexis

mgifford’s picture

@Alexis ya, thanks. I hadn't seen that error in Coder before. Looks like a bug in Coder more than anything else. Although Coder can deal with include files easily enough I think.

Anyways, I was just trying to help nudge this along. This isn't an urgent issue for me at the moment.

klonos’s picture

This module has been mentioned quite a lot in #1293186: Spam - meta: better spam-combating suggestions (and in other related issues too) and it's been proposed to be included in d.o: #1378456: Install Spam module on drupal.org. I think that in order for it to have more chances, it would be a plus if it already had a 7.x version. Reason being that it would make it easier for the initiative to port d.o to D7. So, even if its current 6.x branch maintainers don't have the time to also take the burden of a new 7.x branch, I'm confident that having it would attract others that will eventually step up to the task ;)

PS: ...I know I came to this issue a bit late, but when it comes to @espirates concern back in #23, here's the related issue: #1307170: Make "Follow" button more findable

cweagans’s picture

Killes has said that a spam module port to D7 is not an upgrade blocker for Drupal.org. We can simply turn off the module and reenable it when the port is ready.

That said, I don't think it'll be difficult to port this module. In fact, I started looking at it last night. I wonder if it would be worth making some architectural changes during the port. For instance, I'd like to see the different filters simply become ctools plugins, rather than separate modules.

Anyways, I'm playing with this for a couple hours, so assigning to myself. If you don't hear from me in three days, send in the search parties (or just unassign the issue =P )

cweagans’s picture

Assigned: Unassigned » cweagans

whoops.

calte’s picture

Assigned: cweagans » Unassigned

Search party searching..

cweagans’s picture

Yeah....got sidetracked. Sorry bout that. I'll try to come back around to this when I have time.

ChaseOnTheWeb’s picture

Assigned: Unassigned » ChaseOnTheWeb

I've started working on a port today. If I make substantial progress within the next week, I'll post a sandbox.

ChaseOnTheWeb’s picture

Assigned: ChaseOnTheWeb » Unassigned
klonos’s picture

Does this mean you gave up Chase?

ChaseOnTheWeb’s picture

I'll make a sandbox in the morning and push up what I have. I made some progress, but I do not know how much time I will put toward this in the near future, so I untagged myself.

Like #35-#37, I had issues with Coder Upgrade and started doing the port by hand. I'm somewhat of a novice module developer so I've had to come up to speed on Drupal 6 vs Drupal 7 query API. Most of the queries are ported except a few of the functions/hooks that returned customized WHERE clauses and such. I agree with #39 that some functionality would be better done with ctools plugins, but I've been sidetracked the last few days from reading up on those (my job ends tomorrow, so I'll have some time after that :-/).

I'm not so much giving up as trying not to give the appearance of commitment to this.

Update: Here is the sandbox: http://drupal.org/sandbox/marleythedog/1621054 -- code's still pretty rough right now, not yet to runnable stage.

mgifford’s picture

@marleythedog Seems like it would be worth trying to roll up this as a patch. Glad you made some progress on it.

I'm also assuming you are working off the 6.x-1.x branch of git.

cweagans’s picture

Issue tags: -port, -D7, -drupal 7 +Spam hitlist

Removing unneeded tags and tagging for the d.o spam hitlist

Frank Ralf’s picture

FileSize
91.47 KB

Here's a quick and dirty update of the code from http://drupal.org/sandbox/marleythedog/1621054

I ran it through Coder and amended some of the critical issues. However, the module still throws a lot of errors when trying to activate it.

CarlHinton’s picture

Please, please please ... can you add me as a maintainer so that I can get a workable Drupal 7 dev version of Spam up and running ... err did I say please

cweagans’s picture

No need for you to be a maintainer to get a workable D7 version. Create a sandbox and commit away. When you get to a workable point, just let somebody know where to look for a review.

mgifford’s picture

@Frank Ralf can you submit your code as a patch so that it is easier to review?

I've had problems with other contributions as zips where the project is taken a completely different direction. Not that you'd do that, but patches make it easy to review what has changed.

CarlHinton’s picture

I have created a sandbox at http://drupal.org/sandbox/CarlHinton/1749440 - anyone who wants to help will be made welcome

Frank Ralf’s picture

@CarlHinton
Thanks for your efforts. Feel free to use the code from #49 to incorporate it in your sandbox project. IMHO it's better to join forces instead of creating a separate patch (@Mike).

CarlHinton’s picture

@Frank
I've fixed the problem with installing the Spam API, it was a simple function spelling error. I'm now working through the sub-modules.

Jeremy’s picture

I'm happy to merge it in once it's to a reasonably usable / clean state... please post updates to this issue.

CarlHinton’s picture

@Jeremy
It all installs just fine now including the sub-modules. However there are some issues that need to be ironed out, e.g. I'm getting undefined method DatabaseStatementBase::extend() on the filters tab in admin. I'll drop you a line as soon as this is ready for merging.

geresy’s picture

no joy?:(

alpp’s picture

indeed :( does anybody know about any alternatives for d7? honeypot stops some of the spam, but not all...

adammalone’s picture

Assigned: Unassigned » adammalone

Same as all the other contenders - I'll take a look. If nothing after a week assume I've been categorized as spam.

adammalone’s picture

A small update that I've expanded on the work already done in #53 by CarlHinton.

Sandbox is at: http://drupal.org/sandbox/typhonius/1885762

uno’s picture

I cannot tell you how glad I am that this little gem is finally moving forward.
Thanks to all for your efforts.

cweagans’s picture

For anyone interested, you should take a look at https://drupal.org/project/spam_detect. It's very similar, though a little more lightweight. The default implementation allows you to use Rules for spam detection and filter training, though you can disable the rules integration and just add the filter support programmatically.

apaderno’s picture

Version: master » 6.x-1.x-dev
Assigned: adammalone » Unassigned
Issue summary: View changes
chegor’s picture

Status: Active » Closed (outdated)
apaderno’s picture

Status: Closed (outdated) » Active

This is not an outdated issue, since it's a task for porting the module to Drupal 7.

apaderno’s picture

Issue tags: -Spam hitlist