Drupal core issue blockers [#1122804]

Here's a list of the current Drupal 7 issue blockers that prevent functionality or consistency in the Meta tags module:
http://drupal.org/project/issues/search/drupal?status%5B%5D=Open&issue_t...

If you would like to help development of the module, you can help patch or review any of these core issues.

#1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term
#1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views - note this will not likely be able to be backported to D7 since it would have to break a theme function to use renderable theme output, so we have to figure out some way to workaround for now in D7.

Comment	File	Size	Author
#6	1122804-forum-metatag-fix.patch	4.37 KB	bago
#6

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lsolesen CreditAttribution: lsolesen commented 12 September 2011 at 20:25

Are you still struggling with core issue blockers?

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 13 September 2011 at 14:54

I'm not struggling against them - they can be worked around.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 July 2012 at 04:32

Version:		» 7.x-1.x-dev
Issue tags:		+D7 stable release blocker

Comment #4

bago CreditAttribution: bago commented 24 May 2013 at 14:33

I have latest D7 so #1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term is fixed and I backported the latest patch from #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views but I'm still not able to alter the title for the forum taxonomy term pages, so maybe the 2 issues are not the only blockers.

Comment #5

bago CreditAttribution: bago commented 24 May 2013 at 14:37

Ops, I'm sorry.. I just saw I backported #148145: "Forums" title is not localized that is only related to #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views that still doesn't have any D8 patch attempt.

Comment #6

bago CreditAttribution: bago commented 24 May 2013 at 15:22

File	Size
1122804-forum-metatag-fix.patch	4.37 KB

OK, I fixed it locally, by following this steps:
1- backported #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views to D7 (returning a render array, too, and not the latest D7 patch available there).
(1bis- cloned the forum module in sites/all/modules so to be able to patch it without patching core.)
2- added this code forum_page() (similar to what taxonomy_term_page does)

  // Invoking taxonomy_term_view let metatag to intercept we are on a taxonomy page and inject metatags.
  if ($forum_term->tid) {
    taxonomy_term_view($forum_term, 'full');
  }

This way my forum pages are succesfully using titles and metas defined in metatag for the forum taxonomy.

The patch I attach is for the forum module and is based on 148145-forum-page-cleanup-d7.patch (comment #55 from #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views).

I also tried to simply workaround the forum issues in metatag module with no success, so I ended branching the forum. I don't know if there is a best practice for this, but maybe the best thing would be to create a forum project on drupal.org and put there the fixed forum module so that people that needs it fixed on D7 can simply download the module and it will take precedence on the core module)...

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 24 May 2013 at 17:47

@bago: That's great sleuthing and I really appreciate the work, but can you please post this over on #1662668: Support forum pages until forums supports hook_entity_view()? Thanks :)