Closed (fixed)
Project:
Openlayers
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 May 2011 at 22:14 UTC
Updated:
4 Jan 2014 at 00:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
zzolo commentedHi @ao2. Do you get any sort of Javascript error on that page?
Comment #2
ao2 commented@zzolo, you mentioning javascript made me go deeper on the problem and I think I've found the root cause and come up with a viable fix for it.
Part of problem might be triggered by the XHTML DOCTYPE: CSS selector names are case sensitive with XHTML.
See the attached patch, it can be applied with
git-am. Does it break anything for you?Thanks,
Antonio
Comment #3
zzolo commentedThis worked for me. Thanks for the patch! Committed:
http://drupalcode.org/project/openlayers.git/commit/4764ffd
Comment #4
ao2 commented@zzolo, thanks for committing this, but I don't figure as the author of the change in the git history. I suggested to use
git amfor this very reason, I took time to write a clear detailed commit message, I would have liked that to be taken too. One way to resolve the mis-attribution would be to revert 4764ffd and recommit the patch withgit amagain.You know giving credit is crucial in the Open Source world, where reputation is basically what we sell :)
Regards,
Antonio
Comment #5
zzolo commentedHI @ao2. If you look at the logs, you'll see that I originally committed it with your full message, but chose not to, as I understood how git commit messages should be formatted which is documented here. If you really want me to go back and change it, I can. I do wish to have you attributed correctly.
Comment #6
ao2 commented@zzolo, sorry I didn't look at the full git history, basically what I wanted was my accepted patches to show up in http://drupal.org/user/234884/track/code so we are fine already :)
BTW, can you tell me exactly what was wrong with the commit message I sent? So I can avoid doing the same mistake again in future.
I think the Commit message document you referenced could be updated, with git we can store attribution to the _main_ author in the git history itself, no need to abuse the commit message for that any more, although we can still use these tricks when more authors are involved. And my personal taste is to always have a long commit message which gives more details on the code changes.
Ah, and thanks again for the great OpenLayers module.
Comment #7
zzolo commentedHi @ao2. The one thing that threw me off was that it didn't say "by ao2". But given that you were using git-am then its not all that necessary.