Completing checkout on incoming IPN

Hmm, good point. I'll have to think about it - there isn't an easy answer off the top of my head, and I'll have to decide if it should happen in core or in the payment method module.

Subscribe.

Maybe calling directly this commerce_checkout/module function would do the trick :

<?php
/**
 * Completes the checkout process for the given order.
 */
function commerce_checkout_complete($order) {
  rules_invoke_all('commerce_checkout_complete', $order);
}
?>

Ryan and me talked about this in IRC, and we've inclined the discussion to doing this as a hook_cron() implementation. To be more specific, this cron would query the database like this:

SELECT co.order_id FROM commerce_order co INNER JOIN commerce_payment_transaction cpt ON co.order_id = cpt.order_id WHERE co.status = 'checkout_payment' AND cpt.amount > 0 AND co.changed < NOW() - 3600;

And would then move "Checkout: payment" transations to "Checkout: complete", by calling commerce_checkout_complete().

This would make the user account for anonymous purchases up and running and also trigger the invoice email in one hour if an IPN haven't arrived yet by that time (assuming you also put a call to commerce_checkout_complete() in your payment module which I don't recommend since you make your module dependent on checkout).

For my case this wouldn't suffice as there are cases when customers abandon the payment intentionally, and start a new purchase just after it, like when there's no "Cancel" button and user choose to use another payment method on the last minute.

I come to conclusion that all I needed was a "Complete checkout" operation next to to "edit" on order listings, which may not be a very bad idea.

Also, Ryan said the bellow as a quick and dirty fix for my immediate needs:

Other than that, if I really had to I'd just enable the PHP module and create a Rule on the "After an order status is updated" event with a Custom PHP action that checks the status change and calls commerce_checkout_complete()

It sounds like a "Complete checkout" rule action is not a bad idea at all, I see this being used even with VBO for completing multiple checkouts when this is all you need to do.

Now that I think more about it I think the rule approach is the cleanest (not to say best) way to do that. You have the chance to review and act according to your judgement. And also this wouldn't create nested dependencies between modules.

Well, don't forget that D7 has a version of the D6 module "Poor man's cron" baked in, which ensures that cron will be called whether the site owner has access to cron tabs configuration or not. Most hosts if they don't allow direct access will have some sort of web interface to this.

The main problem I see w/ a Rules approach is that there isn't really a good event for an order to know when to "complete the checkout" process. We can't do it as soon as a payment notification is received w/ the current architecture of the redirected payment checkout pane, because it depends on the order status being Checkout: Payment when a customer returns from the payment gateway. So, we can do one of two things:

1. What recidive mentioned we worked out above: have a cron task in the Payment module that can update orders who have payments received after a reasonable time has elapsed.
2. Change the way the redirected payment checkout pane works so that customers can access the page (and therefore not see a 404 on return from the payment gateway) for any order status of Checkout: Payment or later. I'm not sure I'm comfortable with this, and I still don't think this would accommodate instances of partial payment.

Yes, I agree with @rszrama on cron. There are even free cron services you can use to setup a cron for you website.

The rule action would allow us to implement rules for when changing status of order from "Checkout: payment" to "Checkout: pending" or any later status, for example, to trigger the action. This will not be automated, but would allow us to send user information and order email to user "manually".

@rszrama: I don't understand your option #2 above, can you explain?

I think it's safe to assume an user completed the payment if a. order status = "Checkout: payment" and b. payment status is beetween 'pending' and 'success', but there are not such status in between. I.e. in my case I have two orders for the same customer, one he has abandoned the payment, thus I received a IPN = 'initiated' and then the payment was set to 'pending', and other he has completed the payment and I received the IPN = 'waiting review', and then the payment was set to 'pending' too.

+ subscribing

Just a quick update - I'm actually still undecided on this issue. I want to fix it tomorrow in time for our "1.0 release BoF", but I keep going back and forth as to when to actually "complete" the checkout process. It does seem that an incoming payment notification should be able to do this, in which case we need the return URL from the payment module to still work properly... I'm just still not sure if this is optimal at this point or if we should go with the cron hook until (or if) we update the checkout router to redirect based on the order status...

Hmm, I just realized that we need to fix a longstanding issue pertaining to making checkout page access control extensible. That puts this a little out of scope for what I can do with the 1.0, but I'm planning a 1.1 to come quickly after the 1.0. I'll dig up that issue and see what I can do about allowing the Payment module to hook into there to grant access to the payment URL when you return from the gateway.

See patch dfe1d4d in the sprint repository.

New patch 6cfabe0.

I've committed the patch from #13 and a couple follow-ups providing a better API to support moving some code out of the payment redirection checkout pane.

A few follow-up later, we added two API functions: commerce_payment_redirect_pane_previous_page() and commerce_payment_redirect_pane_next_page() that the redirected payment methods are responsible to call when receiving either a successful or a failure notification.

And done.

Im new to drupal commerce .. how can I allow data users to download my files upon payment to paypal?

ThankYou

Since you're new, I should let you know that you shouldn't go changing titles on old closed issues. Additionally, you want the http://drupal.org/project/commerce_file module I assume.

Im sorry for that, but thank you very much for this http://drupal.org/project/commerce_file.

Hope it will be useful for you to review this post:
Add "Checkout complete page is viewed" event