Hello,

I am experimenting with this module and it seems very interesting, but there is an issue regarding the In-Place Editor of Panels. When using this option in as a renderer in the General "tab" of the template, the In-Place Editor does not appear. When creating another type of page it appears correctly.
I don't know if I am doing something wrong or if it is this way by design.
Can anyone help?
Kind regards,

Duarte

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Letharion’s picture

Status: Active » Closed (cannot reproduce)

I'm not sure I understand when the problem occurs.
Do you have this problem only with a single specific content type?
I have not been able to reproduce this.

berdyshev’s picture

Version: 7.x-1.0-alpha1 » 7.x-1.0-rc1
Status: Closed (cannot reproduce) » Active

I have experienced the same problem. In-Place Editor doesn't work for the site template. But in the same time it works perfect for other panels pages.

merlinofchaos’s picture

Because you can currently only have one IPE on a page, Panels Everywhere was never set up to actually support the IPE.

berdyshev’s picture

Bad news :-( Is this limitation of the In-Place Editor? Can it be fixed?
In this case, why I'm able to choose In-Place Editor on the settings page for the site_template panel? I think if it isn't possible, this option should be disabled for the PanelsEverywhere.

merlinofchaos’s picture

That isn't the only problem that stems from my having wedged Panels Everywhere into Page Manager.

At the time I did it, I said to myself, "brilliant!" because the whole concept of variants turned out to be exactly what i want. Unfortunately, there are quite a few things that being in Page Manager it lets you do:

1) You can set the variant type to be HTTP Response and 404 every page on your site.
2) You can set the panel to not contain the content block, and be unable to view any page on your site.
3) You can turn on settings and features which don't do anything, including the IPE.

Panels Everywhere doesn't really have the access to tell Page Manager not to let you do these things for the site template.

These things are all big usability problems, and the only answer, to me, is that PE needs to be split away from Page Manager entirely. It turns out that it wasn't as brilliant of an idea as I thought. Instead the UI pattern needs to be generalized so that it can be reused, and the PE UI needs to be more like the block UI. Separate from page manager.

The system would work a LOT better then.

Dig1’s picture

Issue summary: View changes
Status: Active » Closed (works as designed)

I am doing some triage on this project. No activity has ocurred on this issue for approximately 12 months. Hopefully ok to Close (works as designed).

DamienMcKenna’s picture

Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Closed (works as designed) » Active

There needs to be some sort of documentation or UX message that indicates that the IPE will not work.

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
2.44 KB

This patch hides the IPE option from the settings form and includes an update script to change existing records to use the standard renderer.

DamienMcKenna’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
FileSize
2.32 KB

D6 backport of the patch above.

DamienMcKenna’s picture

Status: Needs review » Fixed

Both patches have been committed to their respective branches.

  • Commit 0c54b4f on 7.x-1.x by DamienMcKenna:
    Issue #1230100 by DamienMcKenna: Don't allow the IPE be used with site...

  • Commit 63dd44c on 6.x-1.x by DamienMcKenna:
    Issue #1230100 by DamienMcKenna: Don't allow the IPE be used with site...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.