The sample variant has a very clearly defined variable for it, this variable is not checked in the exported subtask so the sample variant is ALWAYS available. Sort of annoying if you're trying to keep the system pristine.

Comments

eclipsegc’s picture

StatusFileSize
new586 bytes

better patch

Letharion’s picture

Assigned: eclipsegc » Letharion
hnln’s picture

It's not always available but the current approach (a check happens in panels_everywhere_ctools_plugin_api) doesn't always work either. I have a featured site_template and the sample variant keeps on popping up (although the setting is switched off). The patched approach is probably better.

dig1’s picture

Issue summary: View changes
Status: Needs review » Closed (fixed)

I am doing some triage on this project. No activity has ocurred on this issue for approximately 24 months. Hopefully ok to Close (fixed).

damienmckenna’s picture

Status: Closed (fixed) » Needs review

This needs to actually be tested, given there's a patch.

eclipsegc’s picture

I have no recollection of writing this patch, BUT i'd be pretty hacked off if I found it again later and found I had a working patch in the queue that was closed, so thanks Damien, I appreciate you keeping this open until at least real dialog happens around it.

Eclipse

damienmckenna’s picture

Status: Needs review » Fixed

Committed. Thanks EclipseGc.

  • Commit d5f1615 on 7.x-1.x by DamienMcKenna:
    Issue #1255228 by EclipseGc: Don't load the sample variant if it's not...

  • Commit 3dd6a33 on 6.x-1.x by DamienMcKenna:
    Issue #1255228 by EclipseGc: Don't load the sample variant if it's not...

  • Commit 03ad505 on 6.x-1.x authored by EclipseGc, committed by DamienMcKenna:
    Issue #1255228 by EclipseGc: Don't load the sample variant if it's not...
  • Commit 943f869 on 6.x-1.x by DamienMcKenna:
    Revert "Issue #1255228 by EclipseGc: Don't load the sample variant if it...

  • Commit 4e7c4ca on 7.x-1.x by DamienMcKenna:
    Revert "Issue #1255228 by EclipseGc: Don't load the sample variant if it...

  • Commit e98be77 on 7.x-1.x authored by EclipseGc, committed by DamienMcKenna:
    Issue #1255228 by EclipseGc: Don't load the sample variant if it's not...
damienmckenna’s picture

I've (reverted and) committed this one again in order to fix the authorship.

eclipsegc’s picture

Oh, thanks! I appreciate that. :-)

Eclipse

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.