Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
search.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Oct 2011 at 03:48 UTC
Updated:
11 Apr 2014 at 18:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jenlamptonComment #2
msonnabaum commentedAgreed. Bunnies are clearly fuzzy.
Comment #3
dave reidlol wut?
Comment #4
jenlamptonMaybe a clearer title will help.
Comment #5
michaelfavia commented@xjm might take issue with this one. http://drupal.org/user/65776 :)
Comment #6
michaelfavia commentedApparently so does google autocorrect :(.
This is a travesty. Some one call the president of the internet .
http://www.google.com/search?&q=bunny+fuzzy
Comment #7
chx commentedbunnies are fluffy. A somewhat disgusting game for example lists it as a phrase. http://en.wikipedia.org/wiki/Chubby_bunny
Comment #8
chx commentedhttp://www.urbandictionary.com/define.php?term=Fuzzy%20Bunnies fuzzy bunnies is NOT going into core. I am happy to debate fluffy vs furry :D
Comment #9
chx commentedWell, ok , the patch actually is about the ear property of the bunny objects not the bunny class themselves. furry bunny ears finds less than half a million in google while fuzzy bunny ears has a million and a half.
Comment #10
seandunaway commenteds/were/are/
Comment #11
xanoIf all else fails, we can always resort to kittens.
Comment #12
damienmckennaFrom a biological accuracy standpoint, this is an exceedingly important patch that fixes a gross inaccuracy thus must be applied immediately.
As @Xano optioned, if for some reason bunnies are no longer to be referenced, then the recommended replacement from a taxonomic perspective (meta data used for selection: small, cute, fuzzy, quantity-of-internet-memes, quality-of-internet-memes, is-a-cat) is "kittens", which also has "fuzzy" ears.
Comment #13
catch#1: update_search_node_test_content-1326932-1.patch queued for re-testing.
Comment #15
damienmckennaIf @chx's feedback is considered valid then perhaps we should consider moving to "fuzzy kittens"?
Comment #16
jenlamptonrerolled.
Comment #17
msonnabaum commentedRe-rolled with proper attribution.
Comment #18
jenlamptontrying with git format-patch instead :)
Comment #19
seandunaway commentedRe: #10: Why are the bunny's ears no longer fuzzy? :)
Comment #20
johnalbinWhen the bunny was here, the bunny's ears were fuzzy. We don't need a novella in a Simple Test to explain why the bunny has departed. Perhaps it left for more carrot-laden gardens. Or perhaps it simply grew up.
Regardless if the patch rollers wish to get a new bunny whose ears are fuzzy, the Grammar Police approve this patch.
Comment #21
seandunaway commentedDon't be upset that you're in jeopardy of being outdone for the Trivial Patch of the Month Award™.
Comment #22
chx commentedYou can't outdo a single period. This patch changes two letters and the semantical meaning of a word.
Comment #23
catchCommitted/pushed to 8.x. Does this need backport?
Comment #24
seandunaway commentedComment #25
seandunaway commentedWhoops, here's the format patch like before.
Comment #26
jenlamptonWorks for me :)
Comment #27
webchickHa. :) Ok.
Committed and pushed to 7.x. Thanks!
Comment #28
David_Rothstein commentedJen, I really wish you would stop engineering for the 80%!
Although it's true that many bunny ears are fuzzy, others are DEFINITELY furry. In fact, it's even possible for the same bunny ear to be fuzzy in one part but furry in another, as I think can be clearly seen from these pictures.
I believe it's important that Drupal support all kinds of bunnies. I therefore propose this followup patch which will allow sites to decide for themselves.
Comment #29
xjmI've been following this issue for awhile, and I think @David_Rothstein has finally identified a proper, robust solution. +1 for #28.
Comment #30
jenlamptonanother layer of abstraction? *sigh*
Comment #31
seandunaway commented'tis the drupal way.
Comment #32
gábor hojtsyI'd also add that localization is still not used in this patch, which will surely upset those German bunnies (as linked by David).
Comment #34
Gaelan commentedReally? An alter hook, not a BunnyEarProcessor class?