[D7] QQ

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  

  ./qq_oauth.inc
  

• ./qq.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function oauth_form($form, &$form_state) {
  function oauth_form_validate($form, &$form_state) {
  function oauth_form_submit($form, &$form_state) {
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./qq.module ./qq.info ./qq_oauth.inc
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

+1 Nice module, actually I've made a QQ module, but as the SDK updates, it's a little old.

Some suggestions:
1. use the the QQ nickname as a suggestion on the final register page.
2. add support on syncing QQ nicknames, photos and so on.
3. add support on qq pengyou, weibo service, this is another big module.

See http://ventral.org/pareview/httpgitdrupalorgsandboxhejinlong1353786git

wow, jinlong, my user_band module allows QQ acount to log in drupal, too.
now, my module has not promot to be a full project yet.

that's fine, actually there're already several QQ modules, but no one seems get too much concern.

so it's time to us to focus on one QQ module, and this is it.

Changed priority from 'major' to 'normal'.

Your priority should not be at 'major' it should only be at 'normal'. The former setting is only for projects that have been awaiting review for 2 weeks or more in line with the project review guidelines.

Sorry, you can only have one application in the queue. (http://drupal.org/node/1383930)
Please close one of them.

QQ is the NO.1 SNS service in China, hope this get passed soon

Did a manual review of the code, and it looks ok, but you still have files in the master branch, there should just be an README.txt pointing to the correct branch. I do not have an QQ account s I could not use for real, but I think it looks like it going t work anyhow. If you just remove the files from the master branch everything should be okay.

A way to speed up review process [META] Review bonus

Sorry for the delay, missed this one.
Only Readme.txt in master, good, but it should only contain info about the correct branch. The instructions you leave in the 7.x-1,x branch. Some minor coding style issues, See attached file. Else, this is thumbs up from me.

Sorry for the delay!

1. Please delete the tags 7.x-1.2, 7.x-1.1, 7.x-1.0 because it looks like you're developing backwards
2. Please put a single new line before and after functions/comment blocks
3. Your indenting is still a little confusing in some places (eg. .module, line 80) please search and correct this (Also automated review is complaining about this http://ventral.org/pareview/httpgitdrupalorgsandboxhejinlong1353786git)
4. Your setting items should be #required
5. It would be better if you'd use camel-case for function names in classes (buildrequesturi -> buildRequestUri) (See coding standarts about classes)

6. if ((bool) db_select('users')->fields('users', array('uid'))->condition('uid', $user->uid, '<>')->condition('name', db_like($form_state['values']['name']), 'LIKE')->range(0, 1)->execute()->fetchField()) {
   

   Please don't be afraid to splitt your code over multiple lines, as it gets really hard to read when you try to put it all into one line.

         $result = db_select('users')
           ->fields('users', array('uid'))
           ->condition('uid', $user->uid, '<>')
           ->condition('name', db_like($form_state['values']['name']), 'LIKE')
           ->range(0, 1)
           ->execute()
           ->fetchField();
         if ($result) {

7. Your commenting your functions but IMHO neither the function descriptions nor the (non-existend) inline comments are very helpful to understand your code -> Please tell us what your doing / Why your doing it this way / Please use inline comments ! ;)
8. All comments should end with ? ! .
9. .module, line 211: All path's should run through url()
10. drupal_add_js('misc/jquery.js'); is that line really necessary ?

11. /**
      *  set config
      */
      function C($name) {

    Description and function name could be a little better

12. If your initialising cURL you should always close it
13. Anyway, why your not using drupal_http_request() there?
14. header('Location: ' . $url . '?' . $query_strings);How can you be sure that not another header will be send later ? please try to use drupal_goto() or do at least something similar to it (correctly finishing drupal and exit()ing)

I'm afraid I can't approve this yet because,

• Coding style is in need of improvement
• It's really hard to understand this module as it's really lacking of inline comments

Please work on this,
regards

hi jinlong,
could you have a look at this application: https://drupal.org/node/1497394
Are your modules doing the same? I'd love to see you joining forces then

Close one， co-operation in another, make a good module!

https://drupal.org/node/1497394 seems more active!

Please get in touch with willietse and make a clear statement whether this or https://drupal.org/node/1497394 should be promoted.

No response yet, contacted jinlong personally.

Hi jinlong

I'd still like to see you and willietse (https://drupal.org/user/431026) collaborate together on the qq login integration module.

I'd like to grant willietse access to your sandbox, add him as co-maintainer and let him merge his additional features into your sandbox.

We can then continue to review the project application (qq https://drupal.org/node/1355762) and approve you both!

that would be really awesome,

please let me know what you think about this.

Cheers

This is great, thanks,
let's continue with this.

I'm afraid there's now a full project of this module: https://drupal.org/project/qq
Sorry, please consider helping them as co-maintainer and join forces.

regards

add module screenshot and git path