XML Transform

welcome,

we got about 150 applications in the queue, all of them want a review, you don't have to put it into the title ;-)

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Please take a moment to make your project page follow tips for a great project page.

Please remove the LICENSE.txt file. Drupal will add the appropriate version automatically during packaging so your repository should not include it.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxdonpwinston1476774git

You can also get a review bonus and we will come back to your application sooner.

regards

oh, yes and only reviewers should assign themselfs (so 2 reviewers won't do the same work twice).

Review of the 7.x-1.x branch:

• ./xml_transform.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function xml_validate($xml, $validation = 'wellformed', $schema_path = null) {
  function libxml_errors_html() {
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

You need to set the status to needs review if you want to get a review, see http://drupal.org/node/532400

You have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

You have not listed any reviews of other project applications in your issue summary as strongly recommended here

We have a huge lack of reviewers, this sentence only says that we recommend reviewing other application so yours get higher priority.

Are you closing because your giving up on this ? :(
I'm very sorry for delay, hope you come another time

donpwinston, your project looks good, but if you want an in-depth review and approval, you'll have to fix indentation, comments, and other syntax issues described in http://ventral.org/pareview/httpgitdrupalorgsandboxdonpwinston1476774git . Drupal has codings standards and contributed modules are expected to follow them if they are to be hosted on drupal.org.

You should also expand your README file (see https://drupal.org/node/447604 ), follow tips ( https://drupal.org/node/997024 ) to make your sandbox project page better.

Note that many of the issues found are minor and should not be required for approval, therefore please do not insist on having them fixed and do not switch the issue to needs work if there are no major issues found.

Doing a manual review, and assigning this to myself, will get back soon.

Manual review:

.gitignore

Please remove the .gitignore file form the repo

Minor: Avoid adding HTML to t()

In the xml_transform_help you adding a lot of html-tags and runt them through t(), you should avoid that

Minor: Implements, not Implementation of

It should be Implements hook_filter_info, not Implementation of hook_filter_info

Minor: Coding style make it hard to read

Your coding style make it hard to read the code and manually validate it, you should really follow the coding standards - if you do so it will be much easier to find security issues and get users to contribute with patches etc.

Defaults to language none?

In xml_transform_node_validate, you have $format = $node->body['und'][0]['format'], why?

Untranslated strings

In xml_transform_libxml_errors_html, you have strings which are not run though t().

Minor: New line is missing

Missing new line in the end of .module could be a problem, please add a finishing new line

And one important issue here, how are you handling the security? There are some big security risks here. You are not adding any permissions, and you do not filter the xml file, or am I missing something?

Forgot to change status.

And unassigning myself...

Closing due to lack of activity. Feel free to reopen if you are still working on this application.