Please ignore this thread. I just need to give testbot a hard time without cluttering up another issue with spam.

Files: 
CommentFileSizeAuthor
#112 1463656-drupal-kernel.patch101.64 KBCrell
PASSED: [[SimpleTest]]: [MySQL] 36,684 pass(es).
[ View ]
#109 1486960_109_drupal-kernel.patch100.64 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 36,683 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#108 1463656-drupal-kernel.patch101.54 KBCrell
PASSED: [[SimpleTest]]: [MySQL] 36,679 pass(es).
[ View ]
#105 1463656-drupal-kernel.patch104.55 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656-drupal-kernel_37.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#104 kernel-benchmark-head.patch284 byteseffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,657 pass(es).
[ View ]
#104 kernel-benchmark-staticloader.patch60.81 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,663 pass(es).
[ View ]
#104 kernel-benchmark-autoloader.patch60.84 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,670 pass(es).
[ View ]
#104 kernel-benchmark-full.patch104.1 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,656 pass(es).
[ View ]
#101 1486960-kernel-testbot-101.patch102.88 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,635 pass(es).
[ View ]
#100 1463656-drupal-kernel.patch105.68 KBCrell
PASSED: [[SimpleTest]]: [MySQL] 36,587 pass(es).
[ View ]
#98 1463656-drupal-kernel-118-nohtaccess.patch105.26 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 36,597 pass(es).
[ View ]
#92 1463656-drupal-kernel.patch105.72 KBCrell
PASSED: [[SimpleTest]]: [MySQL] 36,611 pass(es).
[ View ]
#90 1463656-drupal-kernel.patch105.83 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 36,587 pass(es), 10 fail(s), and 0 exception(s).
[ View ]
#88 1463656-drupal-kernel-88.patch104.86 KBNiklas Fiekas
FAILED: [[SimpleTest]]: [MySQL] 36,565 pass(es), 14 fail(s), and 4 exception(s).
[ View ]
#86 1463656-drupal-kernel-86.patch104.88 KBNiklas Fiekas
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656-drupal-kernel-86.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#85 1463656-drupal-kernel-85.patch304.42 KBNiklas Fiekas
FAILED: [[SimpleTest]]: [MySQL] 36,558 pass(es), 14 fail(s), and 4 exception(s).
[ View ]
#83 1463656-drupal-kernel.patch99.19 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 36,568 pass(es), 11 fail(s), and 9 exception(s).
[ View ]
#80 1486960_80_kernel.patch96.14 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 36,550 pass(es), 15 fail(s), and 12 exception(s).
[ View ]
#78 1486960-kernel-testbot-78.patch95.46 KBeffulgentsia
FAILED: [[SimpleTest]]: [MySQL] 36,543 pass(es), 15 fail(s), and 12 exception(s).
[ View ]
#76 1486960-kernel-testbot-76.patch98.43 KBeffulgentsia
FAILED: [[SimpleTest]]: [MySQL] 36,545 pass(es), 15 fail(s), and 12 exception(s).
[ View ]
#74 1486960-kernel-testbot-74.patch96.28 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#71 1486960-kernel-testbot-71.patch88.9 KBneclimdul
FAILED: [[SimpleTest]]: [MySQL] 36,429 pass(es), 151 fail(s), and 41 exception(s).
[ View ]
#67 1463656-drupal-kernel.patch88 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 36,170 pass(es), 152 fail(s), and 39 exception(s).
[ View ]
1496534_64_account_cmi.patch55.09 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 34,850 pass(es), 8 fail(s), and 0 exception(s).
[ View ]
#62 1463656-drupal-kernel.patch91.58 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,484 pass(es), 219 fail(s), and 39 exception(s).
[ View ]
#59 1463656-drupal-kernel.patch90.76 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]
#55 1463656-drupal-kernel.patch95.3 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]
#53 1463656-drupal-kernel+kernel-niklas.patch82.33 KBNiklas Fiekas
FAILED: [[SimpleTest]]: [MySQL] 35,185 pass(es), 226 fail(s), and 46 exception(s).
[ View ]
#51 1463656-drupal-kernel.patch74.39 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,997 pass(es), 404 fail(s), and 72 exception(s).
[ View ]
#48 1463656-drupal-kernel.patch63.46 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,989 pass(es), 406 fail(s), and 74 exception(s).
[ View ]
#46 1486960_45_kernel.patch147.84 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 32,555 pass(es), 646 fail(s), and 171 exception(s).
[ View ]
#45 1486960_44_kernel.patch143.04 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 32,501 pass(es), 526 fail(s), and 13,003 exception(s).
[ View ]
#42 1486960_42_kernel.patch522.36 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] 34,590 pass(es), 606 fail(s), and 113 exception(s).
[ View ]
#40 1486960_40_kernel.patch522.36 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/lib/Drupal/Core/EventSubscriber/PathSubscriber.php.
[ View ]
#38 1486960_38_kernel.patch1.15 MBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1486960_38_kernel.patch.
[ View ]
#36 1463656_96_kernel.patch106.21 KBcosmicdreams
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656_96_kernel.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#33 1463656-drupal-kernel.patch59.99 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,783 pass(es), 461 fail(s), and 93 exception(s).
[ View ]
#31 1463656-drupal-kernel.patch58.14 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,399 pass(es), 538 fail(s), and 87 exception(s).
[ View ]
#29 1463656-drupal-kernel.patch169.58 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,598 pass(es), 569 fail(s), and 95 exception(s).
[ View ]
#27 1463656-drupal-kernel.patch50.41 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,519 pass(es), 523 fail(s), and 150 exception(s).
[ View ]
#25 1463656-drupal-kernel.patch46.76 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,659 pass(es), 619 fail(s), and 177 exception(s).
[ View ]
#24 1463656-drupal-kernel.patch46.76 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,643 pass(es), 622 fail(s), and 177 exception(s).
[ View ]
#21 1463656-drupal-kernel.patch40.98 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,437 pass(es), 604 fail(s), and 186 exception(s).
[ View ]
#19 1463656-drupal-kernel-niklas.patch37.59 KBNiklas Fiekas
FAILED: [[SimpleTest]]: [MySQL] 35,252 pass(es), 741 fail(s), and 244 exception(s).
[ View ]
#17 1463656-drupal-kernel.patch33.93 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,228 pass(es), 755 fail(s), and 252 exception(s).
[ View ]
#15 1463656-drupal-kernel.patch33.17 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 35,222 pass(es), 756 fail(s), and 252 exception(s).
[ View ]
#13 1463656-drupal-kernel.patch31.96 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,564 pass(es), 1,488 fail(s), and 442 exception(s).
[ View ]
#11 1463656-drupal-kernel.patch36.14 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh --clean.
[ View ]
#9 1463656-drupal-kernel.patch35.36 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#7 1486960-drupal-kernel_7.patch27.3 KBdeviantintegral
FAILED: [[SimpleTest]]: [MySQL] 34,209 pass(es), 1,495 fail(s), and 647 exception(s).
[ View ]
#5 1463656-drupal-kernel.patch27.3 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 34,238 pass(es), 1,485 fail(s), and 644 exception(s).
[ View ]
#2 kernel-testbot.patch25.06 KBCrell
FAILED: [[SimpleTest]]: [MySQL] 33,915 pass(es), 1,540 fail(s), and 641 exception(s).
[ View ]
kernel-testbot.patch25.86 KBCrell
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to enable simpletest module.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, kernel-testbot.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new25.06 KB
FAILED: [[SimpleTest]]: [MySQL] 33,915 pass(es), 1,540 fail(s), and 641 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, kernel-testbot.patch, failed testing.

Status:Needs work» Closed (duplicate)

Status:Closed (duplicate)» Needs review
StatusFileSize
new27.3 KB
FAILED: [[SimpleTest]]: [MySQL] 34,238 pass(es), 1,485 fail(s), and 644 exception(s).
[ View ]

Trying again...

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new27.3 KB
FAILED: [[SimpleTest]]: [MySQL] 34,209 pass(es), 1,495 fail(s), and 647 exception(s).
[ View ]

Status:Needs review» Closed (duplicate)

Status:Closed (duplicate)» Needs review
StatusFileSize
new35.36 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new36.14 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh --clean.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new31.96 KB
FAILED: [[SimpleTest]]: [MySQL] 34,564 pass(es), 1,488 fail(s), and 442 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new33.17 KB
FAILED: [[SimpleTest]]: [MySQL] 35,222 pass(es), 756 fail(s), and 252 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new33.93 KB
FAILED: [[SimpleTest]]: [MySQL] 35,228 pass(es), 755 fail(s), and 252 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new37.59 KB
FAILED: [[SimpleTest]]: [MySQL] 35,252 pass(es), 741 fail(s), and 244 exception(s).
[ View ]

Testing the over-all effects of the changes.

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel-niklas.patch, failed testing.

StatusFileSize
new40.98 KB
FAILED: [[SimpleTest]]: [MySQL] 35,437 pass(es), 604 fail(s), and 186 exception(s).
[ View ]

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new46.76 KB
FAILED: [[SimpleTest]]: [MySQL] 35,643 pass(es), 622 fail(s), and 177 exception(s).
[ View ]

StatusFileSize
new46.76 KB
FAILED: [[SimpleTest]]: [MySQL] 35,659 pass(es), 619 fail(s), and 177 exception(s).
[ View ]

Maybe it jammed? :-(

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new50.41 KB
FAILED: [[SimpleTest]]: [MySQL] 34,519 pass(es), 523 fail(s), and 150 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new169.58 KB
FAILED: [[SimpleTest]]: [MySQL] 35,598 pass(es), 569 fail(s), and 95 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new58.14 KB
FAILED: [[SimpleTest]]: [MySQL] 34,399 pass(es), 538 fail(s), and 87 exception(s).
[ View ]

That was totally wrong.

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new59.99 KB
FAILED: [[SimpleTest]]: [MySQL] 34,783 pass(es), 461 fail(s), and 93 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Issue tags:+wscci-hitlist

Tagging

Status:Needs work» Needs review
StatusFileSize
new106.21 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656_96_kernel.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656_96_kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.15 MB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1486960_38_kernel.patch.
[ View ]

OK, I see what I'm doing wrong, I'm not diffing this code with Drupal 8 HEAD. This patch is my first attempt to do this kind of a patch.

Status:Needs review» Needs work

The last submitted patch, 1486960_38_kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new522.36 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/lib/Drupal/Core/EventSubscriber/PathSubscriber.php.
[ View ]

That's what I get for trying to use format-patch. Here's a regular git diff

Status:Needs review» Needs work

The last submitted patch, 1486960_40_kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new522.36 KB
FAILED: [[SimpleTest]]: [MySQL] 34,590 pass(es), 606 fail(s), and 113 exception(s).
[ View ]

Thanks pifr for finding that. sorry I missed that. Hopefully this one passes.

Status:Needs review» Needs work

The last submitted patch, 1486960_42_kernel.patch, failed testing.

this one should be smaller and effect fewer files. It's curious to see $_GET['q'] be replaced by current_path() since current_path() returns $_GET['q']. Is this a mechanism to replace how the current path is retrieved in the future? should I spread the change of $_GET['q'] to current_path() to every part of drupal?

Status:Needs work» Needs review
StatusFileSize
new143.04 KB
FAILED: [[SimpleTest]]: [MySQL] 32,501 pass(es), 526 fail(s), and 13,003 exception(s).
[ View ]

forgot patch

StatusFileSize
new147.84 KB
FAILED: [[SimpleTest]]: [MySQL] 32,555 pass(es), 646 fail(s), and 171 exception(s).
[ View ]

testing a hypothesis, the only difference between this patch and 45 is that I've change 12 instances of $_GET['q'] in menu.inc and common.inc to current_path().

Status:Needs review» Needs work

The last submitted patch, 1486960_45_kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new63.46 KB
FAILED: [[SimpleTest]]: [MySQL] 34,989 pass(es), 406 fail(s), and 74 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new74.39 KB
FAILED: [[SimpleTest]]: [MySQL] 34,997 pass(es), 404 fail(s), and 72 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new82.33 KB
FAILED: [[SimpleTest]]: [MySQL] 35,185 pass(es), 226 fail(s), and 46 exception(s).
[ View ]

Testing how some changes perform.

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel+kernel-niklas.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new95.3 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]

Starting to get up there in size, but should be much better on the test front...

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review

Once again, a testbot breaker ... or at least, a testbot plugger ...

ID                 Message                                         Timestamp
3,648,263 Requested by test client #664. 20 min 44 sec ago
3,647,833 Test reset by client request.         47 min 29 sec ago
3,647,733 Requested by test client #699. 1 hour 10 min ago
3,647,728 Test reset by client request.         1 hour 10 min ago
3,647,683 Requested by test client #699. 1 hour 33 min ago
3,647,678 Test reset by client request.         1 hour 33 min ago

Hopefully these can shed some light on things ... This is just a select excerpt; the first one is the most common by about 5 times.

[Sun Apr 29 06:31:08 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\AccessDeniedHttpException: "" at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/EventSubscriber/AccessSubscriber.php line 39
[Sun Apr 29 06:31:14 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /aggregator/sources/1"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69
[Sun Apr 29 06:31:38 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /en/admin/config/regional/language"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69
[Sun Apr 29 06:31:38 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /en"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69
[Sun Apr 29 06:32:06 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "" at /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/common.inc line 717
[Sun Apr 29 06:33:14 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /pagedoesnotexist"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69
[Sun Apr 29 06:47:05 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Exception: "Drupal is awesome" at /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/system/tests/modules/error_test/error_test.module line 56
[Sun Apr 29 06:47:05 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Drupal\\Core\\Database\\DatabaseExceptionWrapper: "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaltestbotmysql.bananas_are_awesome' doesn't exist: SELECT * FROM bananas_are_awesome; Array\n(\n)\n" at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Connection.php line 533
[Sun Apr 29 06:47:07 2012] [error] [client 10.20.0.108] PHP Fatal error:  Exception thrown without a stack frame in Unknown on line 0

As long as testbots aren't shielded against this attack ;)

the best way to avoid taking them down is to run at least one of the failing test cases locally.

---
That said, since the PSR-0/classloader changes in D8, my local PHP 5.3.6 frequently manages to freeze and take down my local Apache server on fatal or more severe exceptions. Perhaps something similar is happening on testbots? At least I've the impression something odd is going on in our codebase.

StatusFileSize
new90.76 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]

This is freshly merged from upstream to include the /index.php/ patch. Let's see what happens...

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

This appears to be the showstopper:

PHP Fatal error:  Exception thrown without a stack frame in Unknown on line 0
exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'variable_init' for key 'PRIMARY'' in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Statement.php:58
Stack trace:
#0 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Statement.php(58): PDOStatement->execute(Array)
#1 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Connection.php(506): Drupal\Core\Database\Statement->execute(Array, Array)
#2 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Driver/mysql/Insert.php(34): Drupal\Core\Database\Connection->query('INSERT INTO {se...', Array, Array)
#3 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Lock/DatabaseLockBackend.php(50): Drupal\Core\Database\Driver\mysql\Insert->execute()
#4 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/lock.inc(104): Drupal\Core\Lock\DatabaseLockBackend->acquire('variable_init', 1)
#5 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/bootstrap.inc(834): lock_acquire('variable_init', 1)
#6 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(1527): variable_initialize()
#7 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(1582): DrupalWebTestCase->refreshVariables()
#8 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(529): DrupalWebTestCase->tearDown()
#9 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(369): DrupalTestCase->run()
#10 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(22): simpletest_script_run_one_test('1', 'ContactSitewide...')
#11 {main}

Status:Needs work» Needs review
StatusFileSize
new91.58 KB
FAILED: [[SimpleTest]]: [MySQL] 34,484 pass(es), 219 fail(s), and 39 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new88 KB
FAILED: [[SimpleTest]]: [MySQL] 36,170 pass(es), 152 fail(s), and 39 exception(s).
[ View ]

Status:Needs review» Needs work
Issue tags:-wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review

#67: 1463656-drupal-kernel.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

StatusFileSize
new88.9 KB
FAILED: [[SimpleTest]]: [MySQL] 36,429 pass(es), 151 fail(s), and 41 exception(s).
[ View ]

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1486960-kernel-testbot-71.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new96.28 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

This is #71 plus language negotiation fixes. Depending on test results, I'll commit the interdiff to a suitable branch.

#74: 1486960-kernel-testbot-74.patch queued for re-testing.

StatusFileSize
new98.43 KB
FAILED: [[SimpleTest]]: [MySQL] 36,545 pass(es), 15 fail(s), and 12 exception(s).
[ View ]

#74 changes some bootstrap logic that affects all non-index.php scripts, like the bot runner, which is why it ran 0 tests. This adds a temporary _drupal_bootstrap_legacy() function to work around that.

Status:Needs review» Needs work

The last submitted patch, 1486960-kernel-testbot-76.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new95.46 KB
FAILED: [[SimpleTest]]: [MySQL] 36,543 pass(es), 15 fail(s), and 12 exception(s).
[ View ]

Sweet. That's a 90% failure reduction and 70% exception reduction. This should be the same from a test standpoint, but with a cleaner implementation.

Status:Needs review» Needs work

The last submitted patch, 1486960-kernel-testbot-78.patch, failed testing.

StatusFileSize
new96.14 KB
FAILED: [[SimpleTest]]: [MySQL] 36,550 pass(es), 15 fail(s), and 12 exception(s).
[ View ]

tiny change, a typo may have made one of the tests to fail.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1486960_80_kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new99.19 KB
FAILED: [[SimpleTest]]: [MySQL] 36,568 pass(es), 11 fail(s), and 9 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new304.42 KB
FAILED: [[SimpleTest]]: [MySQL] 36,558 pass(es), 14 fail(s), and 4 exception(s).
[ View ]

Status:Needs work» Needs review
StatusFileSize
new104.88 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656-drupal-kernel-86.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Ugg ... that should have been ..., not .. -- poor testbot :/ Wrong, too. Merge it and then diff next time.

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel-86.patch, failed testing.

StatusFileSize
new104.86 KB
FAILED: [[SimpleTest]]: [MySQL] 36,565 pass(es), 14 fail(s), and 4 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel-88.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new105.83 KB
FAILED: [[SimpleTest]]: [MySQL] 36,587 pass(es), 10 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new105.72 KB
PASSED: [[SimpleTest]]: [MySQL] 36,611 pass(es).
[ View ]

YEAY!!! GREEN!!!

But I noticed something...
Tests are slowed down by 10! minutes with this patch.

Seriously? Why?

Congrats!

OMG Green!

Reviewing...

Status:Needs review» Needs work

+++ b/core/modules/system/tests/xmlrpc.test
@@ -99,7 +103,8 @@ class XMLRPCValidator1IncTestCase extends WebTestBase {
-    $xml_url = url(NULL, array('absolute' => TRUE)) . 'core/xmlrpc.php';
+    global $base_url;
+    $xml_url = $base_url . '/core/xmlrpc.php';

Is this a hack? Suppose better to add another array argument to url()

Status:Needs work» Needs review

Please don't post code reviews here. Let's keep those in the main thread. This issue is just for playing testbot pingpong. :-)

StatusFileSize
new105.26 KB
PASSED: [[SimpleTest]]: [MySQL] 36,597 pass(es).
[ View ]

This is same as #1463656-118: Add a Drupal kernel; leverage HttpFoundation and HttpKernel but without the .htaccess change. I'm curious if that change is required for tests to pass.

effulgentsia: Please remember to use the sandbox, since that's what we're merging from. Straight up patches are just duplicated work. :-(

StatusFileSize
new105.68 KB
PASSED: [[SimpleTest]]: [MySQL] 36,587 pass(es).
[ View ]

StatusFileSize
new102.88 KB
PASSED: [[SimpleTest]]: [MySQL] 36,635 pass(es).
[ View ]

Same patch as in #1463656-125: Add a Drupal kernel; leverage HttpFoundation and HttpKernel, minus xmlrpc.test changes. If this passes, I will open a separate core issue for that, and a wscci sandbox issue to remove it from the kernel work.

@effulgentsia: Mhh ... looks like this has been solved (somehow) in the mean-time. Ensured it passes with clean URLs as well. I looked at the history and made sure it indeed failed at some point. Didn't bisect it, yet. But as long as it passes that's awesome. Do we even need a follow-up?

Do we even need a follow-up?

Yes. See #1593674: Remove unrelated change to xmlrpc.test for details.

StatusFileSize
new104.1 KB
PASSED: [[SimpleTest]]: [MySQL] 36,656 pass(es).
[ View ]
new60.84 KB
PASSED: [[SimpleTest]]: [MySQL] 36,670 pass(es).
[ View ]
new60.81 KB
PASSED: [[SimpleTest]]: [MySQL] 36,663 pass(es).
[ View ]
new284 bytes
PASSED: [[SimpleTest]]: [MySQL] 36,657 pass(es).
[ View ]

Timing testbot as part of #1578090: Benchmark/profile kernel. Will post analysis there.

StatusFileSize
new104.55 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1463656-drupal-kernel_37.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Issue tags:-wscci-hitlist

#105: 1463656-drupal-kernel.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new101.54 KB
PASSED: [[SimpleTest]]: [MySQL] 36,679 pass(es).
[ View ]

Hopefully the last one...

StatusFileSize
new100.64 KB
FAILED: [[SimpleTest]]: [MySQL] 36,683 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

An attempt to reroll after all the PSR-0 tests were committed

You're missing the node test stuff

   function testNodeFeedExtraChannelElements() {
-    ob_start();
-    node_feed(array(), array('copyright' => 'Drupal is a registered trademark of Dries Buytaert.'));
-    $output = ob_get_clean();
-
-    $this->assertTrue(strpos($output, '<copyright>Drupal is a registered trademark of Dries Buytaert.</copyright>') !== FALSE);
+    $response = node_feed(array(), array('copyright' => 'Drupal is a registered trademark of Dries Buytaert.'));
+    $this->assertTrue(strpos($response->getContent(), '<copyright>Drupal is a registered trademark of Dries Buytaert.</copyright>') !== FALSE);

Status:Needs review» Needs work

The last submitted patch, 1486960_109_drupal-kernel.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new101.64 KB
PASSED: [[SimpleTest]]: [MySQL] 36,684 pass(es).
[ View ]

Hopefully for the last time...

A random doc review so I remember all these issues I found for followups.

+++ b/core/includes/bootstrap.incundefined
@@ -4,6 +4,7 @@ use Drupal\Core\Database\Database;
use Symfony\Component\ClassLoader\ApcUniversalClassLoader;
use Drupal\Core\DependencyInjection\ContainerBuilder;
+use Symfony\Component\HttpFoundation\Request;

I would group symfony stuff but thats just me

+++ b/core/includes/file.incundefined
@@ -2517,7 +2509,8 @@ function file_directory_temp() {
+ *   \Symfony\Component\HttpFoundation\StreamedResponse.

Do we need the first backslasg?

+++ b/core/lib/Drupal/Core/ContentNegotiation.phpundefined
@@ -0,0 +1,54 @@
+   * @return

probabaly "@return string"

+++ b/core/lib/Drupal/Core/EventSubscriber/RouterListener.phpundefined
@@ -0,0 +1,96 @@
+   * {@inheritdoc}

I still don't like this...

+++ b/core/lib/Drupal/Core/EventSubscriber/ViewSubscriber.phpundefined
@@ -0,0 +1,128 @@
+class ViewSubscriber implements EventSubscriberInterface {

Has some undocumented functions, but is probably going to be rewritten...

+++ b/core/lib/Drupal/Core/ExceptionController.phpundefined
@@ -0,0 +1,406 @@
+class ExceptionController {

This controller has a lot of functions with missing @return documentation.

+++ b/core/lib/Drupal/Core/LegacyUrlMatcher.phpundefined
@@ -0,0 +1,164 @@
+   * @return Symfony\Component\HttpFoundation\Request $request

Request should be removed

+++ b/core/lib/Drupal/Core/LegacyUrlMatcher.phpundefined
@@ -0,0 +1,164 @@
+   * {@inheritDoc}
+   *
+   * @api

We should rewrite this in drupal api docs

+++ b/core/modules/overlay/overlay.moduleundefined
@@ -299,25 +301,48 @@ function overlay_page_alter(&$page) {
+ * Access callback; determines access to dismiss the overlay accessibility message.

Bigger than 80 chars?

26 days to next Drupal core point release.

I would group symfony stuff but thats just me

Agree.

Status:Needs review» Fixed

The kernel patch is now in(!), so we can close this issue, too.

aspilicious, can you open a new kernel-followup tagged issue with those tweaks?

GO TEAM!

Automatically closed -- issue fixed for 2 weeks with no activity.