Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Add support for the Revisit-After meta tag. See also: (WHATWG meta data wiki
Comment | File | Size | Author |
---|---|---|---|
#15 | metatag-n1498764-15.patch | 2.51 KB | DamienMcKenna |
#9 | metatag-n1498764-9.patch | 2.88 KB | DamienMcKenna |
#4 | 1498764-4-add-revisit-after.patch | 2.35 KB | nick_schuch |
#1 | 1498764-add-revisit-after.patch | 924 bytes | nick_schuch |
Comments
Comment #1
nick_schuch CreditAttribution: nick_schuch commentedBasic implementation. Felt the following options were satisfactory for the type of tag:
- 7 Days
- 1 Month
- 3 Months
- 6 Months
This way it will remain simple.
What are your thoughts?
Comment #2
nick_schuch CreditAttribution: nick_schuch commentedWoops, setting to needs review.
Comment #3
DamienMcKennaIt'd be better to provide a text field for a quantity and a selector for the unit, e.g. 2 days, 1 week, etc.
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedSecond attempt. I have performed the following:
- Setup a new class called "DrupalDateIntervalMetaTag" to handle the two fields.
- Added a css field to make the new field on the form look user friendly.
Comment #5
DamienMcKennaTag.
Comment #6
DamienMcKennaI can't get it to work - no data is saved. :(
Also, please update the description to "The meta tag REVISIT-AFTER defines how often a search engine or spider should come to your website for re-indexing. This tag is used for websites that change their content on a regular basis.", and you forgot to add the #description field to the fieldset:
Comment #7
DamienMcKennaComment #8
DamienMcKennaRelated: #1282806: Upgrade path: Meta tags quick
Comment #9
DamienMcKennaThis fixes a few problems. Firstly, it removes references to the metatag.interval.css file, which wasn't included in any of the patches above; it also adds the meta tag label to each field, so that the vertical tab helper shows a useful string; finally, the description was updated to mention there's little value in using the meta tag so also moves the tag to the end of the Advanced fieldset.
Comment #11
DamienMcKenna#9: metatag-n1498764-9.patch queued for re-testing.
Comment #13
DamienMcKenna#9: metatag-n1498764-9.patch queued for re-testing.
Comment #15
DamienMcKennaThis patch makes the two fields show up in the main fieldset rather than using a nested fieldset, this should resolve the error showing in the testbot for the last patch.
Comment #16
DamienMcKennaCommitted, thanks for the help nick_schuch!
Comment #18
DamienMcKennaNeeds to be ported to D8.
Comment #19
DamienMcKennaComment #20
DamienMcKenna