Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nick_schuch’s picture

Basic implementation. Felt the following options were satisfactory for the type of tag:
- 7 Days
- 1 Month
- 3 Months
- 6 Months

This way it will remain simple.

What are your thoughts?

nick_schuch’s picture

Status: Active » Needs review

Woops, setting to needs review.

DamienMcKenna’s picture

Status: Needs review » Needs work

It'd be better to provide a text field for a quantity and a selector for the unit, e.g. 2 days, 1 week, etc.

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
2.35 KB

Second attempt. I have performed the following:

- Setup a new class called "DrupalDateIntervalMetaTag" to handle the two fields.
- Added a css field to make the new field on the form look user friendly.

DamienMcKenna’s picture

DamienMcKenna’s picture

Status: Needs review » Needs work

I can't get it to work - no data is saved. :(

Also, please update the description to "The meta tag REVISIT-AFTER defines how often a search engine or spider should come to your website for re-indexing. This tag is used for websites that change their content on a regular basis.", and you forgot to add the #description field to the fieldset:

    $form['date-interval'] = array(
      '#type' => 'fieldset',
      '#title' => $this->info['label'],
      '#collapsible' => TRUE,
      '#collapsed' => TRUE,
      '#attached' => array(
        'css' => array(drupal_get_path('module', 'metatag') . '/metatag.interval.css'),
      ),
      '#description' => !empty($this->info['description']) ? $this->info['description'] : '',
    );
DamienMcKenna’s picture

Component: Code » Other tags
DamienMcKenna’s picture

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
2.88 KB

This fixes a few problems. Firstly, it removes references to the metatag.interval.css file, which wasn't included in any of the patches above; it also adds the meta tag label to each field, so that the vertical tab helper shows a useful string; finally, the description was updated to mention there's little value in using the meta tag so also moves the tag to the end of the Advanced fieldset.

Status: Needs review » Needs work
Issue tags: -Nodewords-Metatag feature parity

The last submitted patch, metatag-n1498764-9.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review

#9: metatag-n1498764-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, metatag-n1498764-9.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review

#9: metatag-n1498764-9.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Nodewords-Metatag feature parity

The last submitted patch, metatag-n1498764-9.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
2.51 KB

This patch makes the two fields show up in the main fieldset rather than using a nested fieldset, this should resolve the error showing in the testbot for the last patch.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed, thanks for the help nick_schuch!

Automatically closed -- issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

Needs to be ported to D8.

DamienMcKenna’s picture

Title: Add new meta tag: Revisit-After » Add new meta tag: Revisit-After (D7)
Status: Patch (to be ported) » Fixed
DamienMcKenna’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.