Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Other tags
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Mar 2012 at 22:09 UTC
Updated:
11 Sep 2019 at 19:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nick_schuch commentedBasic implementation. Felt the following options were satisfactory for the type of tag:
- 7 Days
- 1 Month
- 3 Months
- 6 Months
This way it will remain simple.
What are your thoughts?
Comment #2
nick_schuch commentedWoops, setting to needs review.
Comment #3
damienmckennaIt'd be better to provide a text field for a quantity and a selector for the unit, e.g. 2 days, 1 week, etc.
Comment #4
nick_schuch commentedSecond attempt. I have performed the following:
- Setup a new class called "DrupalDateIntervalMetaTag" to handle the two fields.
- Added a css field to make the new field on the form look user friendly.
Comment #5
damienmckennaTag.
Comment #6
damienmckennaI can't get it to work - no data is saved. :(
Also, please update the description to "The meta tag REVISIT-AFTER defines how often a search engine or spider should come to your website for re-indexing. This tag is used for websites that change their content on a regular basis.", and you forgot to add the #description field to the fieldset:
Comment #7
damienmckennaComment #8
damienmckennaRelated: #1282806: Upgrade path: Meta tags quick
Comment #9
damienmckennaThis fixes a few problems. Firstly, it removes references to the metatag.interval.css file, which wasn't included in any of the patches above; it also adds the meta tag label to each field, so that the vertical tab helper shows a useful string; finally, the description was updated to mention there's little value in using the meta tag so also moves the tag to the end of the Advanced fieldset.
Comment #11
damienmckenna#9: metatag-n1498764-9.patch queued for re-testing.
Comment #13
damienmckenna#9: metatag-n1498764-9.patch queued for re-testing.
Comment #15
damienmckennaThis patch makes the two fields show up in the main fieldset rather than using a nested fieldset, this should resolve the error showing in the testbot for the last patch.
Comment #16
damienmckennaCommitted, thanks for the help nick_schuch!
Comment #18
damienmckennaNeeds to be ported to D8.
Comment #19
damienmckennaComment #20
damienmckenna