So we can use image style tokens for images on Taxonomy items, users, etc.

CommentFileSizeAuthor
#9 1525210-9-support-any-entity-type.patch1.58 KBhydra
#2 imagecache_token-metatag-tokenlist-after-patch.JPG83.59 KBsilkogelman
#2 imagecache_token-metatag-tokenlist-before-patch.JPG73.17 KBsilkogelman
#2 imagecache_token-metatag-tokenlist-before-patch.JPG67.81 KBsilkogelman
#1 1525210-support-any-entity-type.patch1.71 KBmerlinofchaos

Comments

merlinofchaos’s picture

merlinofchaos commented
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new 1525210-support-any-entity-type.patch1.71 KB

This patch fixes it to support any entity type, using token.module's entity mapping. While I haven't rigorously tested this, it does work with an image field on a term entity.

It also has the beneficial side effect of fixing notices caused by blindly setting the image-field type on tokens for fields that aren't actually on the nodes (because they're only on other entity types).

silkogelman’s picture

silkogelman commented
StatusFileSize
new imagecache_token-metatag-tokenlist-before-patch.JPG67.81 KB
new imagecache_token-metatag-tokenlist-before-patch.JPG73.17 KB
new imagecache_token-metatag-tokenlist-after-patch.JPG83.59 KB

it seems to work well.

Tested by checking if Taxonomy tokens show up in the Metatag Token list (they did, screenshots attached).

I haven't been able to actually make a og:image metatag with a image-token show up, but that could be a Metatag issue (or a 'me' issue)

Thanks for this patch!

seandunaway’s picture

seandunaway commented
Status: Needs review » Reviewed & tested by the community

Works great, let's get it in. :)

yannickoo’s picture

yannickoo
Location Berlin
commented

Works fine!

Pls’s picture

Pls commented

Works great, not sure why there's no official release with this patch. Let's do it! Would love to hear a word from module maintainer. Thanks.

askibinski’s picture

askibinski commented

Patch works great, nice little module!

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

How about entities attached to entities (eg, field_collections)? This patch doesn't work for my specific case of wanting to grab the first image of a slideshow in a taxonomy term via a multiple-item field collection.

eg [term:field-slideshow-slides:1:field_slide_image:my_image_style_preset_name]

I guess this is sufficiently special-case that it should be a separate issue.

bartezz’s picture

bartezz commented

Works like a charm!

hydra’s picture

hydra commented
StatusFileSize
new 1525210-9-support-any-entity-type.patch1.58 KB

Patch doesn't apply with the "latest" dev version. Rerolled it. Otherwise the Patch does what I would expect the module to do, thanks earl!
@maintainer: Please commit this! It's RTBC now for quit a lot of time.

hydra’s picture

hydra commented

nevermind, ignore #9, I wasn't on the right branch >.< stupid!

Confirm that #1 is working!

hydra’s picture

hydra commented
Status: Reviewed & tested by the community » Closed (fixed)

Commit 2a1a8ae on 7.x-1.x, Thanks!