Port the 'project_release_download_base' setting to D7 and make it per-node-type

Yeah as long as however the file field is being output uses file_create_url() (which all instances of core should be already), then the hook should be a great fit for this.

Can't it know this based on what directory the download is in? Probably something like /files/projects/*?

I'm beginning to suspect that we may want a project module-specific field formatter for the release file fields that just does the output the way we need it to be output.

http://drupalcode.org/project/project.git/commit/ca69fd7 has the setting UI. The field formatter is remaining.

Postponed pending the outcome of #1609382: Port release files with extra metadata to D7 because we need files and stuff in order to, ya know, test a project-module-specific file field formatter.

Adding a Next Steps section.

Coming back to this now that we have feed URLs being displayed on release nodes. I don't hink a field formatter will work since the two places this shows are

• The project_release_files view inserted into node rendering.
• Calling field_view_value() for RSS.

Neither of these is a straightforward field rendering. hook_file_url_alter() could work, but it only knows about the URL, we would have to depend on the path.

#11: correct, hook_file_url_alter()'s only information is the URL itself. The question is: is that acceptable?

I settled on

function project_release_field_attach_view_alter(&$output, $context) {
  if (isset($output['field_release_file'])) {
    foreach (element_children($output['field_release_file']) as $key) {
      if ($wrapper = file_stream_wrapper_get_instance_by_uri($output['field_release_file'][$key]['#file']->uri)) {
        list($scheme, $target) = explode('://', $wrapper->getUri(), 2);
        $path = $wrapper->getDirectoryPath() . '/' . str_replace('\\', '/', trim($target, '\/'));
      }
      $output['field_release_file'][$key]['#suffix'] = '!!';
    }
  }
}

This works for altering the URL everywhere. Now that the setting is per-node-type, we need to know the node type. $context is the field collection, so it isn't immediately known.

Found FieldCollectionItemEntity->hostEntityBundle() for the node type and committed.