The instance AND field is defined in npr_story -- unlike all other fields.

Comments

musicalvegan0’s picture

Status: Active » Closed (duplicate)
crookednumber’s picture

Status: Closed (duplicate) » Active

Re-opening. If I'm reading #2010310: Fix shortcomings of field management correctly, that patch proposed something beyond this ticket (conflating npr_fields and npr_story). I'm more than happy to debate that question, but that really should be a separate issue in the queue. This one is much more modest.

musicalvegan0’s picture

Assuming we are going to keep two different field-related modules (npr_fields and npr_story), it's my opinion that wherever you define the schema for npr_audio should also be the same place you actually create the field; the schema is inseparable from the field it defines, after all.

Right now, the since the schema is defined in npr_fields, it only makes sense to also call field_create_field('npr_audio') there as well.

Field instances should be created in npr_story since instances are attached to content types.